Make InstrumentName.X-offset more robust

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#5919 Make InstrumentName.X-offset more robust

Status: Fixed

Owner: Thomas Morley

Labels: Fixed_2_21_1 (43)

Needs:

Patch:

Type:

Updated: 2020-04-23

Created: 2020-04-18

Creator: Thomas Morley

Private: No

Currently system-start-text::calc-y-offset takes right end of system-start-grobs into account, which may lead to bad results, if one of them is omitted (collapse-height) or moved to the right or other rare cases.
I'd like to propose a patch where we always use the value of indent for the right end and calculate the left end similar as before.
See attached images: the current state, after patch and the ly-test-code.

3 Attachments

instrument-name-x-offset.ly

new-instrument-name-x-offset.png

old-instrument-name-x-offset.png

Discussion

Thomas Morley - 2020-04-18

Attachments has changed:

Diff:

--- old +++ new @@ -1 +1,2 @@ +new-instrument-name-x-offset.png (58.0 kB; image/png) old-instrument-name-x-offset.png (57.6 kB; image/png)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2020-04-18

Attachments has changed:

Diff:

--- old +++ new @@ -1,2 +1,3 @@ +instrument-name-x-offset.ly (4.1 kB; text/x-lilypond) new-instrument-name-x-offset.png (58.0 kB; image/png) old-instrument-name-x-offset.png (57.6 kB; image/png)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2020-04-18

https://codereview.appspot.com/553930044

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-18

Needs: -->

Patch: new --> review

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-18

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2020-04-18

New patch adding regtest
https://codereview.appspot.com/553930044

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-18

Passes make, make check and a full make doc.

Reg test diff attached

Screenshot from 2020-04-18 23-18-07.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Thomas Morley - 2020-04-18
  
  Reg test diff as expected
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-21

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-21

Patch on countdown for April 23rd

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-23

Patch: countdown --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-04-23

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2020-04-23

pushed to staging as:

commit 7aa052aad2f9587864052aa9d0dc9935345ea04b
Author: Thomas Morley thomasmorley65@gmail.com
Date: Sat Apr 18 21:59:51 2020 +0200

Add regtest for issue 5919 instrument-name-system-start-delimiter.ly

commit c5b92038270966a0672eef1dfa934ff7d0c9fc43
Author: Thomas Morley thomasmorley65@gmail.com
Date: Sat Apr 18 14:29:24 2020 +0200

Issue 5919 Make InstrumentName.X-offset more robust Currently system-start-text::calc-y-offset takes right end of system-start-grobs into account, which may lead to bad results, if one of them is omitted (collapse-height) or moved to the right. Instead we always use the value of indent for the right end and calculate the left end similar as before.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2020-04-23

labels: --> Fixed_2_21_1

status: Started --> Fixed

Patch: review -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link: