Menu

#5873 Refactor \markup \pattern

Fixed
2020-04-10
2020-03-30
No

Refactor \markup \pattern

http://codereview.appspot.com/549780045

Discussion

  • Anonymous

    Anonymous - 2020-03-30
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2020-03-30

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2020-04-01
    • Needs: -->
    • Patch: new --> review
    • Type: -->
     
  • Anonymous

    Anonymous - 2020-04-01

    Passes make, make check and a full make doc.

     
  • David Kastrup

    David Kastrup - 2020-04-02
    • Patch: review --> countdown
     
  • David Kastrup

    David Kastrup - 2020-04-02

    Setting this to "Patch-countdown" since it is a prerequisite of issue 5874 (which currently is on countdown and is a final prerequisite for 2.21.0) and the last changes here were of fairly trivial kind.

     
    • Jonas Hahnfeld

      Jonas Hahnfeld - 2020-04-02

      Could you elaborate why 5874 is a prerequisite for 2.21.0? AFAICT it's mostly relevant for Guile 2.x, and the binary releases of 2.21.0 will use Guile 1.8

       
      • David Kastrup

        David Kastrup - 2020-04-02

        Uh, because I am confused? The pertinent patch/issue is a different one (with a convert-ly rule that is better in than not). Thanks for catching me on this. Putting this one back to review. While it's a prerequisite to 5874 on countdown, that one can just be put on wait then.

         
  • David Kastrup

    David Kastrup - 2020-04-02
    • Patch: countdown --> review
     
  • Anonymous

    Anonymous - 2020-04-05
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-04-05

    Patch on countdown for April 6th

     
  • Anonymous

    Anonymous - 2020-04-07
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-04-07

    Patch counted down - please push.

     
  • Anonymous

    Anonymous - 2020-04-09
     
  • Anonymous

    Anonymous - 2020-04-09

    Patch counted down - please push.

     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-04-10
    • labels: --> Fixed_2_21_1
    • status: Started --> Fixed
    • Patch: push -->
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-04-10
    commit 7a5c688187353db154791f3f86140940d5ea4b15
    Author: David Kastrup <dak@gnu.org>
    Date:   Mon Mar 30 16:59:59 2020 +0200
    
        Issue 5873: Refactor \markup \pattern
    
        Also make sure that \pattern markup is called with an exact integer as
        repeat count from \fill-with-pattern: the way it was coded before, it
        didn't mind but that does not seem like a good idea.