Menu

#5811 mf: use python scripting for generating Emmentaler fonts

Fixed
2020-04-12
2020-02-29
No

This gets rid of the ugly generated FontForge scripts, and avoids some
intermediate files.

Remove sequencing on |pfb . This was introduced in e6a5019 (Jun 28
2012, "Clean fonts and docs makefiles"). The race conditions were
fixed in f6dc5e (May 15 2014, "Generate a .pe script for one design
size at a time.")

Remove XXX.fontname files. They appear to be unused.

https://codereview.appspot.com/553580043

Discussion

<< < 1 2 (Page 2 of 2)
  • Anonymous

    Anonymous - 2020-03-28

    Passes make, make check and a full make doc.

    Reg test diff attached

     
  • Anonymous

    Anonymous - 2020-03-28
    • Needs: -->
    • Patch: new --> review
    • Type: -->
     
  • Anonymous

    Anonymous - 2020-03-28
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-03-28

    Patch on countdown for March 29th (minor nit on Rietveld)

     
    • Jonas Hahnfeld

      Jonas Hahnfeld - 2020-03-28

      Please keep in mind that this likely breaks the build with GUB. Not sure if 2.21.0 is a thing before tomorrow...

       
  • Anonymous

    Anonymous - 2020-03-29
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-03-29

    Patch counted down - please push - but Jonas' comment above (about Breaking GUB (probably)) as well as a minor nit on Rietveld before decing when pushing.

     
  • Han-Wen Nienhuys

     
  • Anonymous

    Anonymous - 2020-03-29
    • Needs: -->
    • Patch: new --> needs_work
    • Type: -->
     
  • Anonymous

    Anonymous - 2020-03-29

    fails make

    ...
    Making mf/out/emmentaler-brace.otf 
    Making mf/out/emmentaler-brace.svg 
    Copyright (c) 2000-2014 by George Williams. See AUTHORS for Contributors.
     License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
     with many parts BSD <http://fontforge.org/license.html>. Please read LICENSE.
     Based on sources from 11:21 UTC 24-Sep-2017-ML-D.
     Based on source from git with hash: 
    Copyright (c) 2000-2014 by George Williams. See AUTHORS for Contributors.
     License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
     with many parts BSD <http://fontforge.org/license.html>. Please read LICENSE.
     Based on sources from 11:21 UTC 24-Sep-2017-ML-D.
     Based on source from git with hash: 
    Making mf/out/emmentaler-brace.woff 
    Copyright (c) 2000-2014 by George Williams. See AUTHORS for Contributors.
     License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
     with many parts BSD <http://fontforge.org/license.html>. Please read LICENSE.
     Based on sources from 11:21 UTC 24-Sep-2017-ML-D.
     Based on source from git with hash: 
    Traceback (most recent call last):
      File "/home/james/lilypond-git/mf/gen-emmentaler-brace.fontforge.py", line 46, in <module>
        os.remove(tmp)
    OSError: [Errno 2] No such file or directory: 'tmp.feta-brace-scaled.pfb'
    /home/james/lilypond-git/build/.././mf/GNUmakefile:137: recipe for target 'out/emmentaler-brace.svg' failed
    make[1]: *** [out/emmentaler-brace.svg] Error 1
    make[1]: *** Waiting for unfinished jobs....
    Cannot open /home/james/lilypond-git/build/mf/tmp.feta-brace-scaled.pfb
    The requested file, tmp.feta-brace-scaled.pfb, does not exist
    Traceback (most recent call last):
      File "/home/james/lilypond-git/mf/gen-emmentaler-brace.fontforge.py", line 45, in <module>
        font.mergeFonts(tmp)
    EnvironmentError: No font found in file "tmp.feta-brace-scaled.pfb"
    /home/james/lilypond-git/build/.././mf/GNUmakefile:137: recipe for target 'out/emmentaler-brace.otf' failed
    make[1]: *** [out/emmentaler-brace.otf] Error 1
    /home/james/lilypond-git/build/../stepmake/stepmake/generic-targets.make:6: recipe for target 'all' failed
    make: *** [all] Error 2
    
     
  • Han-Wen Nienhuys

     
  • Anonymous

    Anonymous - 2020-03-29
    • Needs: -->
    • Patch: new --> review
    • Type: -->
     
  • Anonymous

    Anonymous - 2020-03-29

    Passes make, make check and a full make doc

     
  • Anonymous

    Anonymous - 2020-03-31
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-03-31

    Patch on countdown for April 2nd

     
  • Anonymous

    Anonymous - 2020-04-02
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-04-02

    Patch counted down - please push.

     
  • Anonymous

    Anonymous - 2020-04-07

    This can be pushed - I cannot find any evidence that it has (otherwise can you put in the commit ID?)

    Patch counted down - please push

     
  • Han-Wen Nienhuys

    still waiting for 2.21.0 to be released
    
     
  • Anonymous

    Anonymous - 2020-04-09
    • Patch: push --> waiting
     
  • Han-Wen Nienhuys

    commit 2d40ef8ced63607cc1a9b2a0bc6a1fd1122af8c4 (HEAD -> pymf, origin/staging)
    Author: Han-Wen Nienhuys hanwen@lilypond.org
    Date: Fri Mar 27 19:20:32 2020 +0100

     
  • Han-Wen Nienhuys

    • labels: --> fixed_2_21_0
    • status: Started --> Fixed
    • Patch: waiting --> push
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-04-11
    • labels: fixed_2_21_0 --> Fixed_2_21_1
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-04-11
    • Patch: push -->
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-04-12

    FWIW the required changes for GUB are here: https://github.com/gperciva/gub/pull/72

     
<< < 1 2 (Page 2 of 2)