Menu ▾ ▴

#5572 Compile modified C++ files automatically before testing

Fixed
Dan Eble
Fixed_2_21_0 (565)
Build
2019-10-21
2019-10-14
Dan Eble
No

make test-baseline and make check ought to ensure that lilypond is up to date before running it.

They ought to ensure that fonts are up to date too, but that's outside the scope of this ticket.

Discussion

  • Dan Eble

    Dan Eble - 2019-10-16
     

  • Anonymous

    Anonymous - 2019-10-16
    • Needs: -->
    • Patch: new --> review
    • Type: --> Build
     

  • Anonymous

    Anonymous - 2019-10-16

    Passes make, make check and a full make doc

     

  • Anonymous

    Anonymous - 2019-10-19
    • Patch: review --> countdown
     

  • Anonymous

    Anonymous - 2019-10-19

    Patch on countdown for 21st Oct.

     

    Last edit: Anonymous 2019-10-19

  • Anonymous

    Anonymous - 2019-10-21
    • Patch: countdown --> push
     

  • Anonymous

    Anonymous - 2019-10-21

    Patch counted down - please push.

     

  • Dan Eble

    Dan Eble - 2019-10-21
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     

  • Dan Eble

    Dan Eble - 2019-10-21

    commit 73aaa6d299468ac8c4d70fe10ca28bd6f64cc285 (HEAD -> pushed/issue-5572-make-check, origin/staging)
    Author: Dan Eble nine.fierce.ballads@gmail.com
    Date: Mon Oct 14 09:35:26 2019 -0400

    Issue 5572/2: Contributor's Guide updates

    commit 0d7744aad06e2f29ae6b1fec9b22cba02a6f469e
    Author: Dan Eble nine.fierce.ballads@gmail.com
    Date: Fri Oct 11 18:57:48 2019 -0400

    Issue 5572/1: Compile modified C++ files automatically before testing

The main change is to make sure lilypond and scripts are up to date
before running tests.  Build fonts too, though this is only sufficient
to handle builds following a `make clean`.

Other changes:

* Make a single baseline copy of fonts instead of replicating them in
  every subdirectory with tests.

* If the developer has forgotten to create a baseline, try to catch it
  quickly.

* Fix warnings about multiple sets of rules for local-test by renaming
  one of the targets lysdoc-test.