Menu

#5567 Allow slurs instead of brackets with tuplets

Fixed
None
2020-05-01
2019-10-04
No

Allow slurs instead of brackets with tuplets

Older editions often use slurs with tuplets. This patch
creates a new property ('tuplet-slur'), which toggles this
notation style. Note that 'bracket-visibility must be set
to #t for the slurs to appear with beamed notes.

(In the future, 'bracket-visibility might automatically be set
to #t.)

http://codereview.appspot.com/581110043

1 Attachments

Discussion

  • Werner LEMBERG

    Werner LEMBERG - 2019-10-04

    I'm shepherding this patch for David Nalesnik.

     
  • Anonymous

    Anonymous - 2019-10-06

    Passes make, make check and a full make doc.

    But changes two reg test diffs - see attached

     
  • Werner LEMBERG

    Werner LEMBERG - 2019-10-06

    Should be fixed now.

     
  • Anonymous

    Anonymous - 2019-10-08
    • Patch: review --> new
     
  • Anonymous

    Anonymous - 2019-10-09
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2019-10-09

    passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2019-10-11
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2019-10-11

    Patch on coutdown for Oct 13th

     
  • Anonymous

    Anonymous - 2019-10-13
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2019-10-13

    Patch counted down - please push.

     
  • Werner LEMBERG

    Werner LEMBERG - 2019-10-14
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Werner LEMBERG

    Werner LEMBERG - 2019-10-14

    Pushed to staging as

    commit fa6c70e39af7aba1f3b49b2e8141635888cd7373
    Author: David Nalesnik david.nalesnik@gmail.com
    Date: Sat Feb 11 13:19:16 2017 -0600

    Issue 5567: allow slurs instead of brackets with tuplets
    
    Older editions often use slurs with tuplets.  This patch
    creates a new property ('tuplet-slur'), which toggles this
    notation style.  Note that 'bracket-visibility must be set
    to #t for the slurs to appear with beamed notes.
    
    (In the future, 'bracket-visibility might automatically be set
    to #t.)
    
     
  • Valentin Villenave

    Doc: mention tuplet-slur in Changes and in NR 1.2.1.2 "Tuplets"

    See issue #5567 for David Nalesnik’s original patch.
    Documenting why the bracket-visibility default behavior
    isn’t suited to tuplet-slurs allows me to explicitely
    point towards the relevant snippet for more clarity,
    and to add a couple of additional internal references.

    https://codereview.appspot.com/559930043

     
    • Valentin Villenave

      Oops, git-cl reopened this issue instead of opening a new one. Bleh, that’s just a fairly minor doc patch so hopefully we can get it in without too much fuss :-)

       
      • Anonymous

        Anonymous - 2020-05-01
         
  • Anonymous

    Anonymous - 2020-05-01
    • status: Started --> Fixed
    • Needs: -->
    • Patch: new -->
    • Type: -->
     
Auth0 Logo