Menu

#5507 ly: Adding turkish-makam.ly

Fixed
Enhancement
2019-04-15
2019-04-07
No

Contribution from Adam Good

[A] fantastic place to start with support for transposable Turkish makam, with transposing limitations due to unfortunate limitations in the theory itself.

[At least it] gets us started without the requirememnts of having to include Graham Breed's regular.ly i.e. this enhancemnet works with the stnadard LilyPond codebase.

I've done TONS of testing, have goals for down the road that involve more support if only there were more accidental glyphs available.

ly: Adding turkish-makam.ly

  1. Support for better transposition.
    Not all transpositions are possible
    but, it's a huge improvement over
    current makam.ly

  2. The current makam.ly has no
    support for key signatures due
    to poor transposition. This new
    file adds support for 201 makams.

Example:
\key g \rast
brings up the key signature for makam rast.

  1. Support for key signature accidental
    order for these makams.

Most makams use combinations of
accidentals

Example:
backwards flat PLUS sharp sign.
This puts everything in order as per
the current theory in Turkish music.

  1. Carefully added padding pairs
    between accidentals in key signatures.

http://codereview.appspot.com/548610043

Discussion

  • Anonymous

    Anonymous - 2019-04-07
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2019-04-07

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2019-04-12
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2019-04-12

    Patch on countdown for April 15th.

     
  • Anonymous

    Anonymous - 2019-04-15
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2019-04-15

    Patch counted down, please push to staging.

     
  • Anonymous

    Anonymous - 2019-04-15
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2019-04-15
    ly: Adding turkish-makam.ly staging
    author  Adam Good <goodadamgood@gmail.com>  
        Mon, 15 Apr 2019 20:27:31 +0100 (20:27 +0100)
    committer   James Lowe <pkx166h@runbox.com> 
        Mon, 15 Apr 2019 20:32:30 +0100 (20:32 +0100)
    commit  db818c1220dd1e1197ecd3b9609dd069f2e9f978