#5477 Broken links in website pages

[Valentin Villenave]

Many links (particularly @rcontrib{} links) on the website point to 2.21 directories that are not online yet, as you can verify by doing:

wget -r --ignore-tags=img \
  --exclude-directories=doc,website,attic,download \
  --reject jpg,pdf,png,css,jz,gz,sh,bz2,exe \
  --accept  "*.html" http://lilypond.org ;
grep -r "2\.21" lilypond.org

Attached is a list of affected pages; it mostly comes down to helpus.itexi, manual.itexi and a few other places. Some broken links are visible on:
http://lilypond.org/help-us.html
http://lilypond.org/faq.html
and all translated versions.

This appears to be due to an oddity in the way make/website.make works; unlike create-weblinks-itexi.py, it seems not to use VERSION_STABLE or VERSION_DEVEL but rather MINOR_VERSION, hence the broken links.

[John Mandereau]

I'm looking at this, a patch shall come real soon now.

[John Mandereau]

I don't know why git-cl issued "Update attempt returns error code 404", but here's the patch anyway:
http://codereview.appspot.com/361790043

[Anonymous]

Passes make, make check and a full make doc (patchy tests do not build the website though - just to remind people).

[Anonymous]

Patch on countdown for March 3rd

[Anonymous]

Patch counted down - please push to staging.

[Anonymous]

Patch counted down - please push to staging.

[Anonymous]

Website: use VERSION_DEVEL rather than MAJOR.MINOR master staging
author John Mandereau john.mandereau@gmail.com
Wed, 6 Mar 2019 06:55:49 +0000 (07:55 +0100)
committer John Mandereau john.mandereau@gmail.com
Wed, 6 Mar 2019 06:55:49 +0000 (07:55 +0100)
commit dceebb052ffc133b10a4eeb8e7068843ae085dfa

[Phil Holmes]

This is now fixed on the website - for website security, changed scripts (like make-website) have to be manually copied to the trusted-scripts directory. I did that this afternoon when I asw that the help-us page was still wrong, and it's now right.