https://codereview.appspot.com/567560043
Thomas Morley wrote :
the following code is problematic
{ \set fingeringOrientations = #'(left) \override Fingering #'stencil = ##f <g'-2 c''-4 > %% chord needs two elements to trigger the bug }
Versions 2.12.3 up to 2.16.2 print correctly, without error
Versions 2.18.2 up to 2.19.82 print correctly, but return:
programming error: Infinity or NaN encountered
Current master does:
Segmentation fault (core dumped)
And this is what gdb has to say:
I’m wondering if it isn’t another skyline problem; setting the Direction to up or down doesn’t segfault but setting it to a horizontal direction (either right or left) does.
I thought this illegal stencil Box would be passed by the New_fingering_engraver, but of the two following snippets, only the first one triggers the bug:
A workaround it not set the stencil property to
##f
but rather to#empty-stencil
.Fix #5476: segfault when Fingering stencil set to #f.
https://codereview.appspot.com/567560043
Diff:
Passes make, make check and a full make doc but the reg tests aren't good.
See:
https://cloud-u8zj2dc4b.yourownnet.eu/s/fD5Tjo2Frz3g9p5 (~1mb)
Yowza. Not good indeed. Thanks for catching this James, I should’ve paid more attention!
Fix regtests (conditional should only apply to horizontal fingerings)
https://codereview.appspot.com/567560043
Passes make, make check and a full make doc.
Reg test diffs attached
Patch on countdown for May 11th