I don't see that difference in the repeat-percent test on my system (my new experimental Docker container based on Ubuntu 18.04). I'm sure the tests are running because test-output-distance changes.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Not seeing the repeat-percent change either, and a code review does not turn up anything that would warrant seeing a change here. I don't see a GC problem either.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2018-08-13
I re-ran your patch on my work machine (that also runs the same version of Ubuntu as the one I have at home where I ran the patch yesterday) and also did NOT get that reg test turn up. :(
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2018-08-13
Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2018-08-13
Patch on countdown for August 16th.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2018-08-16
Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2018-08-16
Patch counted down - please push.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Diff:
Passes make, make check and a full make doc. Reg test diff attached
reg test diff
I don't see that difference in the repeat-percent test on my system (my new experimental Docker container based on Ubuntu 18.04). I'm sure the tests are running because test-output-distance changes.
Not seeing the repeat-percent change either, and a code review does not turn up anything that would warrant seeing a change here. I don't see a GC problem either.
I re-ran your patch on my work machine (that also runs the same version of Ubuntu as the one I have at home where I ran the patch yesterday) and also did NOT get that reg test turn up. :(
Patch on countdown for August 16th.
Patch counted down - please push.
commit 86495867567bb55921aed147522751ebcd35575c (HEAD -> pushed/issue-5399-reuse-find-context-above, origin/staging)
Author: Dan Eble nine.fierce.ballads@gmail.com
Date: Fri Aug 10 20:10:19 2018 -0400