Menu ▾ ▴

#5368 Reduce allocations in Grob dimension caching

Fixed
Dan Eble
Fixed_2_21_0 (565)
Enhancement
2018-07-14
2018-07-04
Dan Eble
No

Reduce allocations in Grob dimension caching
Add Optional<T> offering some of the features of C++17 std::optional.

http://codereview.appspot.com/359770043

Discussion

  • Anonymous

    Anonymous - 2018-07-05
    • Description has changed:

    Diff:
    • Needs: -->
    • Patch: new --> review
     

  • Anonymous

    Anonymous - 2018-07-05

    Passes make, make check and a full make doc.

     

  • Dan Eble

    Dan Eble - 2018-07-06

    Hide Optional in Dimension_cache and pare it down

    http://codereview.appspot.com/359770043

     

  • Anonymous

    Anonymous - 2018-07-08
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     

  • Anonymous

    Anonymous - 2018-07-08

    Passes make, make check and a full make doc.

     

  • Anonymous

    Anonymous - 2018-07-10
    • Patch: review --> countdown
     

  • Anonymous

    Anonymous - 2018-07-10

    Patch on countdown for July 13th

     

  • Anonymous

    Anonymous - 2018-07-13
    • Patch: countdown --> push
     

  • Anonymous

    Anonymous - 2018-07-13

    Patch counted down - please push.

     

  • Dan Eble

    Dan Eble - 2018-07-14
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     

  • Dan Eble

    Dan Eble - 2018-07-14

    commit d73e5d689b11172f91ad7ad6a36b3167aa63d08a (HEAD -> pushed/issue-5368-dimension-cache-allocation, origin/staging)
    Author: Dan Eble nine.fierce.ballads@gmail.com
    Date: Sat Jun 30 07:31:57 2018 -0400

    Issue 5368: Reduce allocations in Grob dimension caching
using a pared-down imitation of C++17 std::optional.