LilyIssues / Issues / #5351 Spacing_spanner::prune_loose_columns: prune in-place

#5351 Spacing_spanner::prune_loose_columns: prune in-place

Status: Fixed

Owner: David Kastrup

Labels: Fixed_2_21_0 (565)

Needs:

Patch:

Type: Enhancement

Updated: 2018-07-16

Created: 2018-06-19

Creator: David Kastrup

Private: No

Spacing_spanner::prune_loose_columns: prune in-place

This saves a tiny amount of time and memory.

http://codereview.appspot.com/351720043

Discussion

Anonymous - 2018-06-20

Description has changed:

Diff:

Needs: -->

Patch: new --> needs_work
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-06-20

Fails make..

make[1]: *** [out/spacing-determine-loose-columns.o] Error 1 make[1]: *** Waiting for unfinished jobs.... /home/james/lilypond-git/lily/spacing-loose-columns.cc: In function 'void set_loose_columns(System*, const Column_x_positions*)': /home/james/lilypond-git/lily/spacing-loose-columns.cc:36:50: warning: conversion to 'int' from 'std::vector<Grob*>::size_type {aka long unsigned int}' may alter its value [-Wconversion] int loose_col_count = posns->loose_cols_.size (); ^
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- David Kastrup - 2018-06-20
  
  Doesn't fail here, so do you have the relevant error message? It would be above what you quoted. The warning below is just a parallel compilation on an unrelated file that is completing independently after spacing-determine-loose-columns bombed out.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - David Kastrup - 2018-06-22
    
    Ping?
    
    If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
    - David Kastrup - 2018-07-10
      
      Setting to "Patch_new" since I don't appear to get any reply otherwise.
      
      If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Kastrup - 2018-07-10

Patch: needs_work --> new
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Kastrup - 2018-07-10

Cater to C++98

http://codereview.appspot.com/351720043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Kastrup - 2018-07-10

I am stupid

http://codereview.appspot.com/351720043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Kastrup - 2018-07-10

Add a comment according to Pál's suggestion even though it turns out his suggestion would have worked after all for even more contorted reasons

http://codereview.appspot.com/351720043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-07-11

Needs: -->

Patch: new --> review

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-07-11

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-07-13

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-07-13

Patch on countdown for July 16th

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-07-16

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-07-16

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-07-16

labels: --> Fixed_2_21_0

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-07-16

author David Kastrup <dak@gnu.org> Tue, 19 Jun 2018 23:55:26 +0100 (00:55 +0200) committer David Kastrup <dak@gnu.org> Mon, 16 Jul 2018 07:45:53 +0100 (08:45 +0200) commit 796061b92550c6125f5a0313c21f35e56be6378a
If you would like to refer to this comment somewhere else in this project, copy and paste the following link: