Menu ▾ ▴

#5301 Refactor mark events ...

Started
Dan Eble
None
needs_work
Enhancement
2018-04-09
2018-04-06
Dan Eble
No

Refactor mark events ...

Split mark events into three classes:
* default rehearsal mark
* specific rehearsal mark
* ad-hoc mark

In anticipation of adding a fourth class with both a symbolic label
and text markup, stop using the 'label property to hold the markup of
ad-hoc marks. Use 'text instead.

http://codereview.appspot.com/340650043

Discussion

  • Anonymous

    Anonymous - 2018-04-06
    • Description has changed:

    Diff:
    • Needs: -->
    • Patch: new --> review
     

  • Anonymous

    Anonymous - 2018-04-06

    Passes make, make check and a full make doc.

     

  • Anonymous

    Anonymous - 2018-04-09
     

  • Anonymous

    Anonymous - 2018-04-09

    I'll leave this on Review - there is a comment from David K on Rietvel.

     

  • Dan Eble

    Dan Eble - 2018-04-09
    • Patch: review --> needs_work