Use convert -strip

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#5290 Use convert -strip

Status: Fixed

Owner: Bernhard M. Wiedemann

Labels: Fixed_2_21_0 (565)

Needs:

Patch:

Type: Enhancement

Updated: 2018-03-20

Created: 2018-03-13

Creator: Bernhard M. Wiedemann

Private: No

Use convert -strip

to not add timestamps to .png output files
to make build reproducible

See https://reproducible-builds.org/ for why this is good.

Without this patch, files in the openSUSE lilypond-doc package would differ for every build:
/usr/share/doc/packages/lilypond/Documentation/pictures/baer-flat-bw.png
/usr/share/doc/packages/lilypond/Documentation/pictures/baer-flat-gray.png
/usr/share/doc/packages/lilypond/Documentation/pictures/henle-flat-bw.png
...

http://codereview.appspot.com/339350043

Discussion

Anonymous - 2018-03-14

Description has changed:

Diff:

Needs: -->

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-03-14

Passes make, make test-baseline and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- David Kastrup - 2018-03-14
  
  What? "make test-baseline" is supposed to be run on a known working version (usually before applying the patch). The actual check is done running "make check" and highlights the differences to "make test-baseline".
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - Anonymous - 2018-03-16
    
    Ah good, someone does pay attention to my notes ;).
    
    I don't believe that the patch test workflow 'tests' changes to the makefile scripts, so I ran the full set of builds that I could and make test-baseline is at least exercising the reg tests doing a make check would be pointless.
    
    If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-03-16

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-03-16

Patch on countdown for March 19th

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-03-19

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-03-19

Patch counted down - Bernhard can you make a git-formatted patch against current master and attach it, I can then push it for you. James

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Bernhard M. Wiedemann - 2018-03-20

attached

0001-Use-convert-strip.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-03-20

labels: --> Fixed_2_21_0

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-03-20

author Bernhard M. Wiedemann <bwiedemann@suse.de> Mon, 3 Jul 2017 05:29:37 +0000 (07:29 +0200) committer James Lowe <pkx166h@gmail.com> Tue, 20 Mar 2018 11:33:23 +0000 (11:33 +0000) commit d1d5f436a190929e38145cf8be7d4fa63b077b46
If you would like to refer to this comment somewhere else in this project, copy and paste the following link: