Menu

#5024 Rework the Preinit framework into something simpler

Verified
Maintainability
2017-02-16
2017-01-01
No

Rework the Preinit framework into something simpler

The previous introduction of the Preinit class had to work with
uninitialized data members in a state before construction.

Particularly for data structures like vector classes, this
was quite awkward. Moving such structures into a separate
class initialized before the smobifying base class fixes
this deficiency and makes the behavior much more reliable,
at the cost of making the class hierarchy a bit more nested.

http://codereview.appspot.com/318200043

Discussion

  • Anonymous

    Anonymous - 2017-01-02
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2017-01-02

    Happy New Year!

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2017-01-05
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2017-01-05

    Patch on countdown for Jan 8th

     
  • Anonymous

    Anonymous - 2017-01-08
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2017-01-08

    Patch counted down - please push.

     
  • David Kastrup

    David Kastrup - 2017-01-08
    • labels: --> Fixed_2_19_55
    • status: Started --> Fixed
    • Patch: push -->
    • Type: Enhancement --> Maintainability
     
  • David Kastrup

    David Kastrup - 2017-01-08

    Pushed to staging as
    commit 6786ba7b5cd73f94eec0a49fd68d0e6d9d283437
    Author: David Kastrup dak@gnu.org
    Date: Sun Jan 1 10:14:14 2017 +0100

    Issue 5024: Rework the Preinit framework into something simpler
    
    The previous introduction of the Preinit class had to work with
    uninitialized data members in a state before construction.
    
    Particularly for data structures like vector classes, this
    was quite awkward.  Moving such structures into a separate
    class initialized before the smobifying base class fixes
    this deficiency and makes the behavior much more reliable,
    at the cost of making the class hierarchy a bit more nested.
    
     
  • Federico Bruni

    Federico Bruni - 2017-02-16
    • status: Fixed --> Verified