Menu

#4883 make calc-blot from bar-line.scm public

Verified
Documentation
2016-06-23
2016-06-05
No

make calc-blot from bar-line.scm public

To facilitate defining custom-bar-lines using
ly:round-filled-box

http://codereview.appspot.com/299250044

Discussion

  • Thomas Morley

    Thomas Morley - 2016-06-05
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> needs_work
     
  • Thomas Morley

    Thomas Morley - 2016-06-13

    bar-line::draw-filled-box

    http://codereview.appspot.com/299250044

     
  • Anonymous

    Anonymous - 2016-06-14
    • Needs: -->
    • Patch: new --> review
    • Type: --> Documentation
     
  • Anonymous

    Anonymous - 2016-06-14

    Passes make, make check andf a full make doc.

     
  • Anonymous

    Anonymous - 2016-06-15
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-06-15

    Patch on countdown for June 18th.

     
  • Anonymous

    Anonymous - 2016-06-18
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2016-06-18

    Patch counted down - please push.

     
  • Thomas Morley

    Thomas Morley - 2016-06-19
    • labels: --> Fixed_2_19_44
    • status: Started --> Fixed
    • Patch: push -->
     
  • Thomas Morley

    Thomas Morley - 2016-06-19

    pushed to staging as:

    commit 893eca274995ace99dc5ed46b2d0711cd1cb0ab0
    Author: Thomas Morley thomasmorley65@gmail.com
    Date: Sun Jun 5 17:19:57 2016 +0200

    Issue 4883 Implement public definition of bar-line::draw-filled-box
    
    bar-line::draw-filled-box calls the hereby renamed procedure
    bar-line::calc-blot to determine the blot diameter.
    It will be used in:
      make-simple-bar-line
      make-thick-bar-line
      make-tick-bar-line
    This simplifies user-customized bar-lines, which are build with
    ly:round-filled-box.
    No need to copy/paste the blot-calculating procedure anymore.
    
     
  • Federico Bruni

    Federico Bruni - 2016-06-23
    • status: Fixed --> Verified