Menu

#4753 make select-head-glyph and note-head::calc-glyph-name more robust

Verified
Enhancement
2016-03-02
2016-01-24
No

make select-head-glyph and note-head::calc-glyph-name more robust

In case style is not a symbol.
A TODO is inserted, not sure how to deal with.

http://codereview.appspot.com/282270043

Discussion

  • Anonymous

    Anonymous - 2016-01-25

    Passes make, make check and a full make doc

     
  • Anonymous

    Anonymous - 2016-01-25
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Thomas Morley

    Thomas Morley - 2016-01-25
     
  • Thomas Morley

    Thomas Morley - 2016-01-25

    Here a code-example, which triggered the problem:

    \version "2.19.35"
    {
      \override NoteHead.after-line-breaking =
        #(lambda (grob) (ly:grob-property grob 'glyph-name))
      c''1
    }
    

    returned:

    /home/hermann/lilypond/usr/share/lilypond/current/scm/output-lib.scm:374:43: In procedure symbol->string in expression (symbol->string style):
    /home/hermann/lilypond/usr/share/lilypond/current/scm/output-lib.scm:374:43: Wrong type argument in position 1 (expecting symbol): ()
    
     
  • Anonymous

    Anonymous - 2016-01-26
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2016-01-26

    Passes make, make check and a full make doc

     
  • Anonymous

    Anonymous - 2016-01-27
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-01-27

    Patch on countdown for January.30th

     
  • Anonymous

    Anonymous - 2016-01-30
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2016-01-30

    Patch counted down - please push.

     
  • Thomas Morley

    Thomas Morley - 2016-01-30
    • labels: --> Fixed_2_19_36
    • status: Started --> Fixed
    • Patch: push -->
     
  • Thomas Morley

    Thomas Morley - 2016-01-30

    pushed to staging as

    commit 5b2517c7f542a333fdfbfe9e0f15d2ac8fc4d8d1
    Author: Thomas Morley thomasmorley65@gmail.com
    Date: Mon Jan 25 00:53:34 2016 +0100

    make select-head-glyph and note-head::calc-glyph-name more robust
    
    Issue 4753
    
    In case style is not a symbol.
    
     
  • Simon Albrecht

    Simon Albrecht - 2016-03-02
    • status: Fixed --> Verified