Menu

#4634 Simplify coord-rotate

Verified
Maintainability
2015-10-20
2015-10-09
No

Simplify coord-rotate

This does not fix the problem that (sin PI) is not really zero because
of the MPU working with higher precision than PI is specified, but at
least it makes the code nicer to read and modify.

http://codereview.appspot.com/263690043

Discussion

  • Anonymous

    Anonymous - 2015-10-11
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2015-10-11

    Pases make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2015-10-14

    Patch on countdown for October 17th

     
  • Anonymous

    Anonymous - 2015-10-14
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2015-10-17
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2015-10-17

    Patch counted down - please push

     
  • David Kastrup

    David Kastrup - 2015-10-17

    Pushed to staging as
    commit e860e146ccecf07d42aa53de885916931950245e
    Author: David Kastrup dak@gnu.org
    Date: Fri Oct 9 16:17:49 2015 +0200

    Issue 4634: Simplify coord-rotate
    
    This does not fix the problem that (sin PI) is not really zero because
    of the MPU working with higher precision than PI is specified, but at
    least it makes the code nicer to read and modify.
    
     
  • David Kastrup

    David Kastrup - 2015-10-17
    • labels: --> Fixed_2_19_29
    • status: Started --> Fixed
    • Patch: push -->
     
  • Phil Holmes

    Phil Holmes - 2015-10-20
    • status: Fixed --> Verified