LilyIssues / Issues / #4399 Patch: Add French-specific note names

Google Importer - 2015-05-17

Originally posted by: v.villenave

(No comment was entered for this change.)

Owner: v.villenave

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-05-17

Originally posted by: dak@gnu.org

Italian does not have the -x? It would probably be weird to see "rex" as a notename.

The main problem I see with admitting accented note names that it becomes hard to explain why ré (string #\x72 #\xe9) is a valid notename while ré (string #\x72 #\x65 #\x301) isn't. At least with user-defined Unicode, one has some likelihood that the user enters his characters in the same way each time.

Admittedly, the Latin-1 plane has been around long enough that there is some likelihood its glyphs tend to be represented by its own Unicode characters rather than more complex compositions. At least outside of file names or other "normalized" code spaces.

What's with double flat?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-05-17

Originally posted by: v.villenave

"rex" is nowhere near as strange as "six". But these double-accidentals are rare enough for it not to matter too much.

You have a point with inconsistent unicode identifiers. But the é character I’m referring to is common enough (we have a dedicated key for it on our Azerty keyboards, and it’s even one of the most prominent keys in the Bépo keyboard layout).

Double-flat: I’m not sure what a sensible shortcut might be... How about ß? :-)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-05-17

Originally posted by: pkx1...@gmail.com

http://codereview.appspot.com/239930043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-05-17

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: passes tests. Includes a full make doc

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-05-17

Originally posted by: dak@gnu.org

Patchy the autobot says: passes tests.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-05-18

Originally posted by: v.villenave

Add -x suffix in italiano; "ré" comes before "re" in French

http://codereview.appspot.com/239930043

Labels: -Patch-review Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-05-18

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: fails to apply to current master

Labels: -Patch-new Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-05-18

Originally posted by: v.villenave

Add convert rules

http://codereview.appspot.com/239930043

Labels: -Patch-needs_work Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-05-19

Originally posted by: dak@gnu.org

Patchy the autobot says: Patch does not apply to current master.

Labels: -Patch-new Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Trevor Daniels - 2015-12-07

Description has changed:

Diff:

status: Started --> Accepted

Needs: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Trevor Daniels - 2015-12-07

The patch provided by Valentin seems quite close to being finished, but he appears to have lost interest. Reverting this issue to Status:Accepted as it is over 6 months since the last action, so permitting another Dev to finish it off. Leaving patch status as needs_work; the comments on Reitveld make it clear what is needed.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Valentin Villenave - 2016-02-22

Greetings everybody,
I’m back in the loop. Here’s my new patch set for this issue, please let me know if it looks better:
https://codereview.appspot.com/288290043/

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-02-23

status: Accepted --> Started

assigned_to: Valentin Villenave

Patch: needs_work --> new
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-02-23

Patch: new --> needs_work
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-02-23

Fails make doc - remove the newly added @end itemize in the changes.tely edit.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Valentin Villenave - 2016-02-23

Oh, indeed. Thanks!

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Valentin Villenave - 2016-02-23

Remove typo (fix doc build).

http://codereview.appspot.com/288290043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-02-23

Needs: -->

Patch: new --> needs_work

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-02-23

Fails make check

regression/note-names.ly

Not a lot to go on

--snip--

Processing ./50/lily-a98c808c.ly' Parsing... Renaming input to:/home/jlowe/lilypond-git/input/regression/note-names.ly'
error: program too old: 2.19.37 (file requires: 2.19.38)
Interpreting music...
Preprocessing graphical objects...
Calculating line breaks...
Drawing systems...
Writing header field texidoc' to./50/lily-a98c808c.texidoc'...
Writing ./50/lily-a98c808c-1.signature
Layout output to ./50/lily-a98c808c.eps'... Layout output to./50/lily-a98c808c-1.eps'...
Writing ./50/lily-a98c808c-systems.texi...
Writing ./50/lily-a98c808c-systems.tex...
Writing ./50/lily-a98c808c-systems.count...
Writing timing to 50/lily-a98c808c.profile...

--snip--

Dissecting...
Writing snippets...
Processing...
Processing /home/jlowe/lilypond-git/build/out/lybook-testdb/snippet-names-2063213751245854722.ly
command failed: /home/jlowe/lilypond-git/build/out/bin/lilypond -I /home/jlowe/lilypond-git/input/regression -dbackend=eps --formats=ps -djob-count=7 -dseparate-log-files -dinclude-eps-fonts -dgs-load-lily-fonts --header=texidoc -I /home/jlowe/lilypond-git/Documentation/included/ -ddump-profile -dcheck-internal-types -ddump-signatures -danti-alias-factor=1 -I "./" -I "/home/jlowe/lilypond-git/build/input/regression" -I "/home/jlowe/lilypond-git/input/regression" --formats=eps -deps-box-padding=3.000000 -dread-file-list -dno-strip-output-dir "/home/jlowe/lilypond-git/build/out/lybook-testdb/snippet-names-2063213751245854722.ly"
Child returned 1
Error ignored by lilylib
Error trapped by lilypond-book

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Valentin Villenave - 2016-02-23

Use current LILYPOND_VERSION in regtest.

http://codereview.appspot.com/288290043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-02-23

Needs: -->

Patch: new --> review

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-02-23

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-02-27

Description has changed:

Diff:

--- old +++ new @@ -12,3 +12,5 @@ French input language \(an unrelated but welcome addition\). [http://codereview.appspot.com/239930043](http://codereview.appspot.com/239930043) + +EDIT: Feb 27 2016 - the updated Rietveld link is now https://codereview.appspot.com/288290043

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2016-02-27

Patch on countdown for March 1st.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Patch: Add French-specific note names

Issue Tracker for LilyPond

Searches

Help

#4399 Patch: Add French-specific note names

Discussion