collision glissando accidental (includes workaround)

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#40 collision glissando accidental (includes workaround)

Status: Verified

Owner: nobody

Labels: fixed_2_17_25 (1) Regression (247)

Needs:

Patch:

Type: Ugly

Updated: 2013-09-05

Created: 2006-09-20

Creator: Anonymous

Private: No

Originally created by: *anonymous

Originally created by: gpermus@gmail.com
Originally owned by: k-ohara5...@oco.net

\header {
texidoc = "
the glissando line doesn't stop before an accidental.
I'd give this an even lower priority if possible.

Workaround:
@code{ \\once \\override Glissando #'gap = #0.5 }
@code{ \\once \\override Glissando #'extra-offset = #'(-0.5 . 0)}
produces a gliss which does an (IMO) acceptable job of avoiding
collision.
"
reportedin = "2.7.5"
}

\version "2.9.16"
\layout{ragged-right=##t}
\relative c'' {
\override Glissando #'thickness = #3
c4\glissando ces
}

1 Attachments

c-glissando-accidental.preview.png

Related

Issues: #1860
Issues: ~~#4807~~

Discussion

Google Importer - 2008-05-30

Originally posted by: v.villenave

(Reproduced with 2.11.47)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2010-01-18

Originally posted by: percival.music.ca@gmail.com

(No comment was entered for this change.)

Labels: -Priority-Low Priority-Medium
Owner: ---

foo.preview.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-08-06

Originally posted by: mts...@gmail.com

Fix posted here.

http://codereview.appspot.com/4801083

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-08-07

Originally posted by: percival.music.ca@gmail.com

(No comment was entered for this change.)

Labels: Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-08-20

Originally posted by: percival.music.ca@gmail.com

(No comment was entered for this change.)

Labels: -type-Collision Type-Ugly

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-08-21

Originally posted by: mts...@gmail.com

Fixed with [rb3c0b773bde05b3971f087ed6c5f4fb40a1b20b1].

Status: Fixed

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-08-22

Originally posted by: ColinPKC...@gmail.com

Pushed as [rb3c0b773bde05b3971f087ed6c5f4fb40a1b20b1] by Mike Solomon.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-08-29

Originally posted by: brownian.box@gmail.com

Should be tagged as "fixed_2_15_9" ?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-08-29

Originally posted by: percival.music.ca@gmail.com

yes

Labels: -Priority-Medium fixed_2_15_9

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-09-01

Originally posted by: brownian.box@gmail.com

This is fixed, but I've submitted another one, issue 1860.

Status: Verified

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-27

Originally posted by: lemzw...@googlemail.com

At least in version release/2.17.16-1-45-g7ea1588, this is broken again.
Attached is a current rendering of the original issue. Do we have a regtest for this?

Labels: -Patch-review -fixed_2_15_9 Regression
Status: Accepted

c-glissando-accidental.preview.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-28

Originally posted by: PhilEHol...@googlemail.com

glissando-accidental.ly

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-28

Originally posted by: lemzw...@googlemail.com

Thanks. And indeed, it fails.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-08-13

Originally posted by: k-ohara5...@oco.net

First bad commit is
[r987fc85646498b0d8bfa89b85ad1375d942a53f0]
Date:   Fri Sep 14 07:20:22 2012 +0200

    Uses exact horizontal skylines for accidental placement.

issue 2811

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-08-24

Originally posted by: k-ohara5...@oco.net

It turns out the wrong patch set was pushed for this issue, while the final reviewed patch set is more robust and co-exists with the patch for issue 2811.
I pushed a correction to bring the code in agreement with the final patch from Mike's review, as [rb47350d1efb1128b2a8ea13f340dd5e3a53f0735].

Labels: fixed_2_17_25
Owner: k-ohara5...@oco.net
Status: Fixed

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-08-25

Originally posted by: Elu...@gmail.com

(No comment was entered for this change.)

Status: Verified

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-09-05

Originally posted by: k-ohara5...@oco.net

Issue 2942 has been merged into this issue.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link: