Menu
▾
▴
#3972 Patch: Don't depend on obsolete Guile features.
Originally created by: *anonymous
Originally created by: dsch... (code.google.com)@gmail.com
Originally owned by: dsch... (code.google.com)@gmail.com
Don't depend on obsolete Guile features.
* Replace scm_listify with scm_list_*. It's been deprecated for a long time, and is gone in Guile 2.1.
* Use scm_protects only in Guile 1.x. It's internal in Guile 2.0 (and obsolete as far as Lilypond is concerned).
This makes Lilypond build with Guile 2.1.
Discussion
Originally posted by: dsch... (code.google.com)@gmail.com
(No comment was entered for this change.)
Owner: dsch...@gmail.com
Originally posted by: pkx1... (code.google.com)@gmail.com
Patchy the autobot says: passes make, make check and a full make docs.
Labels: -Patch-new Patch-review
Originally posted by: pkx1... (code.google.com)@gmail.com
David has some comments.
Keeping patch on Patch-review for now.
Originally posted by: pkx1... (code.google.com)@gmail.com
Patch on countdown for July 5th 2014
(I can keep this on the countdown next time round if there is still more discussion otherwise can you change the patch to 'needs-work' if it actually does need more work.
Labels: -Patch-review Patch-countdown
Originally posted by: dsch... (code.google.com)@gmail.com
Fix incorrect comment. Support scm_protects in Guile 2.0. Give an error instead of #f when it's not available.
http://codereview.appspot.com/109230043
Labels: -Patch-countdown Patch-new
Originally posted by: pkx1... (code.google.com)@gmail.com
Patchy the autobot says: passes make, make check and a full make docs.
Labels: -Patch-new Patch-review
Originally posted by: pkx1... (code.google.com)@gmail.com
Patch on countdown for July 8th 2014
Labels: -Patch-review Patch-countdown
Originally posted by: pkx1... (code.google.com)@gmail.com
Patch counted down - please push
Labels: -Patch-countdown Patch-push
Originally posted by: pkx1... (code.google.com)@gmail.com
Patch counted down - please push
Originally posted by: pkx1... (code.google.com)@gmail.com
author Devon Schudy <dschudy@gmail.com>
Wed, 25 Jun 2014 00:55:44 +0000 (20:55 -0400)
committer James Lowe <pkx166h@gmail.com>
Tue, 15 Jul 2014 05:19:38 +0000 (06:19 +0100)
commit [rb0e291860d77581f0ff27d5b26f8632fc0bdbeba]
Please close Rietveld issue.
Many thanks
Labels: -Patch-push Fixed_2_19_11
Status: Fixed
Originally posted by: PhilEHol...@googlemail.com
(No comment was entered for this change.)
Status: Verified