Patch: when parent is a PaperColunm, align using noteheads extent

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#3254 Patch: when parent is a PaperColunm, align using noteheads extent

Status: Verified

Owner: nobody

Labels: Janek_alignment_changes (15) Fixed_2_19_9 (16)

Needs:

Patch:

Type: Enhancement

Updated: 2014-08-09

Created: 2013-03-17

Creator: Anonymous

Private: No

Originally created by: *anonymous

Originally created by: janek.li...@gmail.com
Originally owned by: janek.li...@gmail.com

don't abort aligning when grob's parent is a PaperColumn

This results in all lyrics being aligned according to self-alignment-X,
including unassociated lyrics that were previously all left-aligned.

this should pass regtests with expected differencies in the following files:
lyrics centered instead of left-aligned:
alignment-order.ly
midi/lyrics-addlyrics-midi.ly
page-spacing-nonstaff-lines-between.ly
page-spacing-nonstaff-lines-top.ly
lyric-no-association-rhythm.ly
hairpin-ending.ly
markup-special-characters.ly
span-bar.ly
lyric-tweak.ly
instrument-name.ly
instrument-name-pedal-lyrics.ly

http://codereview.appspot.com/7564044

Related

Issues: ~~#4030~~
Issues: #4182

Discussion

<< < 1 2 (Page 2 of 2)

Google Importer - 2014-06-21

Originally posted by: pkx1...@gmail.com

PAsses make, make check and a full make doc

Reg test diff

https://www.hightail.com/download/ZUcyb2VDOC9reEJOeDhUQw

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-22

Originally posted by: janek.li...@gmail.com

Issue 247 has been merged into this issue.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-22

Originally posted by: janek.li...@gmail.com

also fix issue 247

http://codereview.appspot.com/108110044

Labels: -Patch-review Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-22

Originally posted by: janek.li...@gmail.com

remove comment from documentation that is no longer valid

http://codereview.appspot.com/108110044

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-22

Originally posted by: pkx1...@gmail.com

Passes make, make check and a full make doc

reg test diffs here

https://www.hightail.com/download/ZUcyb2VKMHd3NUpFQmNUQw

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-22

Originally posted by: janek.li...@gmail.com

Thanks, James! All changes are expected. I think the patch is ready to be included in the next countdown :)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-23

Originally posted by: janek.li...@gmail.com

Patch on countdown for June 26th.

Labels: -Patch-review Patch-countdown

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-26

Originally posted by: pkx1...@gmail.com

Patch counted down - please push

Labels: -Patch-countdown Patch-push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-26

Originally posted by: janek.li...@gmail.com

pushed as

commit [rc73b41b3e7be6d7280c6336cf03610cd7aed3000]
Author: Janek Warchoł <lemniskata.bernoullego@gmail.com>
Date:   Sun Mar 17 21:22:32 2013 +0100

    Issue 3254: align unassociated lyrics using NoteColumn extent.

    This makes unassociated lyrics behave consistently with
    associated lyrics. Until now, "standalone" lyrics
    were left-aligned (more precisely: their X-offset was 0);
    changing self-alignment-X didn't have any effect on them.
    Now it's possible to specify their alignment, like with
    associated lyrics.

    Also, this changes how issue 104 was resolved (see 0b14e8b2e122d) -
    alignment of syllables that are associated to a context without
    noteheads is no longer aborted - and solves issue 247.

    Later on, these changes should allow using aligned_on_parent for
    other grobs (such as DynamicTexts).

    Expected changes in output: all lyrics should be centered by default.

Labels: -Patch-push Fixed_2_19_9

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-26

Originally posted by: janek.li...@gmail.com

(No comment was entered for this change.)

Status: Fixed

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-26

Originally posted by: dak@gnu.org

Just as a sort of PostScriptum: one possible motivation for the previous different behavior was using Lyrics for something else entirely: notes, editorial remarks, footnote anchors or whatnot.

So it's conceivable that some scores are negatively affected.

But that's just a wild guess at history. I agree that it does not appear to make sense to let lyric alignment be dependent on voice association.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-26

Originally posted by: janek.li...@gmail.com

Yes, and getting old behaviour back is trivial :)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-26

Originally posted by: k-ohara5...@oco.net

The previous behavior was for issue 104 (which remains fixed)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-26

Originally posted by: dak@gnu.org

Regarding #38: indeed, good sleuth work. Any idea *why* that issue would remain fixed? It would appear that the behavior flagged there would be exactly the behavior that is described to be the goal of this issue?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-28

Originally posted by: janek.li...@gmail.com

Probably the title of this issue is confusing (updated). The goal of this issue is not just to restore old code - rather, i'm adding new code that handles the situation better.

The situation before patch for issue 104 was: when LyricText wasn't attached to notes, it got attached to PaperColumn, and aligned using PaperColumn extent (which could be very big and thus result in weird alignment).

Han-Wen "fixed" that by aborting alignment in such cases, so that the LyricTexts got X-offset 0 (incidentally, this was roughly equivalent to being left-aligned).

My patch doesn't use PaperColumn extent either, but instead of aborting alignment, it uses a "replacement" extent. It's done by finding all noteheads that belong to the PaperColumn that is being considered and aligning LyricTexts on that. (If there are no noteheads, LyricText is simply aligned on an empty extent - as if there was an infinitely-narrow notehead there.)

In other words, my patch ensures that Lyrics will be aligned on respective noteheads, regardless of whether they are explicitly attached to them using associatedVoice or not.

Summary: Patch: when parent is a PaperColunm, align using noteheads extent

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-28

Originally posted by: janek.li...@gmail.com

Issue 247 has been merged into this issue.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-07-07

Originally posted by: fedel...@gmail.com

(No comment was entered for this change.)

Status: Verified

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-08-09

Originally posted by: janek.li...@gmail.com

(No comment was entered for this change.)

Labels: Janek_alignment_changes

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

<< < 1 2 (Page 2 of 2)