LilyIssues / Issues / #3254 Patch: when parent is a PaperColunm, align using noteheads extent

Google Importer - 2013-03-17

Originally posted by: janek.li...@gmail.com

(No comment was entered for this change.)

Owner: janek.li...@gmail.com

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-17

Originally posted by: janek.li...@gmail.com

% some code for testing:

\markup "associated lyrics:"
{ c'2 c' d' d' }
\addlyrics { foo bar la mmm }

\markup "unassociated lyrics:"
<<
{ c'2 c' d' d' e'1 }
\new Lyrics { \lyricmode { foo2 bar __ la mmm } }
>>

\markup "associated lyrics:"
{ c'2 c' d' d' }
\addlyrics {
\override LyricText #'self-alignment-X = #RIGHT
foo bar la mmm
}

\markup "unassociated lyrics:"
<<
{ c'2 c' d' d' }
\new Lyrics {
    \lyricmode {
      \override LyricText #'self-alignment-X = #RIGHT
      foo2 bar la mmm
    }
}
>>

<<
{ c'4 d'2 e'4 }
\new Lyrics \lyricmode { \skip 4 lal4 lil4 }
>>

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-18

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: passes make, make test and a full make doc. Reg tests are here: https://www.yousendit.com/download/UVJpQmtUSEJiV3kwYjhUQw

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-18

Originally posted by: janek.li...@gmail.com

Thanks. The changes are expected.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-18

Originally posted by: janek.li...@gmail.com

(No comment was entered for this change.)

Labels: GSoC-LyricProject

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-18

Originally posted by: janek.li...@gmail.com

calculate extent of notecolumn and use it for aligning

http://codereview.appspot.com/7564044

Labels: -Patch-review Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-18

Originally posted by: janek.li...@gmail.com

I've checked regtests myself, so i don't think it's necessary to have James test it again. As with previous patchset, there are differencies in a number of files where unassociated lyrics are used, all expected.

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-18

Originally posted by: janek.li...@gmail.com

add regtest

http://codereview.appspot.com/7564044

Labels: -Patch-review Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-18

Originally posted by: janek.li...@gmail.com

(No comment was entered for this change.)

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-18

Originally posted by: dak@gnu.org

Regarding comment #7: please don't skip the testing by Patchy. It does its work in a clean, controlled environment from scratch, something that in-tree regtesting doesn't. Things like files forgotten to get checked in are rather frequent. Messing up the test baseline and not actually seeing changes also.

Labels: -Patch-review Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-18

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: passes make, make test and a full make doc. Reg test diffs here https://www.yousendit.com/download/UVJqNnFBQ3RRR2RqQTlVag

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-19

Originally posted by: janek.li...@gmail.com

@David:
ok. It's just that i feel guilty of overloading James when i send two versions of several patches a day, sometimes containing just a change in comments.

As for the regtest output, graphical differencies are exactly as expected. I'm a bit surprised by cell differencies, because i didn't get them on my machine, but these changes are not big so i think it's ok.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-19

Originally posted by: janek.li...@gmail.com

(No comment was entered for this change.)

Blocking: lilypond:3239

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-19

Originally posted by: janek.li...@gmail.com

make the method for calculating extents more generic and move it to PaperColumn

http://codereview.appspot.com/7564044

Labels: -Patch-review Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-19

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: passes make, make test and a full make doc. Reg test diffs here
https://www.yousendit.com/download/UVJpb3BGeWFFd2M5WThUQw

Makes no difference to me if you send multiple patches a day. I just run the script and go do something else instead. The computer does all the work.

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-19

Originally posted by: janek.li...@gmail.com

@James: ok.

All visual differences in regtests expected and desired. All other differences (in logs, cell count...) appear to be harmless.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-20

Originally posted by: janek.li...@gmail.com

This patch should be rebased on issue 3239, i.e. i think we should first reorganize self-alignment-interface without making any substantial changes, and then discuss how to handle this situation.

Blockedon: lilypond:3239

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-20

Originally posted by: janek.li...@gmail.com

(No comment was entered for this change.)

Blocking: -lilypond:3239

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-23

Originally posted by: pkx1...@gmail.com

Patch on Countdown for March 26 - 19:00 GMT

Labels: -Patch-review Patch-countdown

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-24

Originally posted by: janek.li...@gmail.com

This patch isn't quite ready for countdown; we need to finish issue 3259 and 3239 before going back to discussion about this.

Labels: -Patch-countdown Patch-waiting

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-03

Originally posted by: janek.li...@gmail.com

This is now a part of issue 3239 (they are too closely related to be kept separate).

Mergedinto: 3239
Status: Duplicate

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-21

Originally posted by: janek.li...@gmail.com

Un-duplicate this issue - i will solve it before issue 3239.

Blockedon: -lilypond:3239
Labels: -Patch-waiting
Mergedinto:
Status: Accepted

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-21

Originally posted by: janek.li...@gmail.com

Issue 3254: align unassociated lyrics using NoteColumn extent.

This makes unassociated lyrics behave consistently with
associated lyrics. Until now, "standalone" lyrics
were left-aligned (more precisely: their X-offset was 0);
changing self-alignment-X didn't have any effect on them.
Now it's possible to specify their alignment, like with
associated lyrics.

Later on, this should also allow correctly aligning_on_parent
other grobs (such as DynamicTexts).

Expected changes in output: all lyrics should be centered by default.

http://codereview.appspot.com/108110044

Labels: Patch-new
Status: Started

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-21

Originally posted by: pkx1...@gmail.com

Passes make, make check and a full make doc.

Reg test diffs here:

https://www.hightail.com/download/ZUcyb2VCZEtIcWM5WThUQw

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-21

Originally posted by: janek.li...@gmail.com

update documentation, fix texidoc formattic (acc. to Werner comment)

http://codereview.appspot.com/108110044

Labels: -Patch-review Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Patch: when parent is a PaperColunm, align using noteheads extent

Issue Tracker for LilyPond

Searches

Help

#3254 Patch: when parent is a PaperColunm, align using noteheads extent

Related

Discussion