Menu ▾ ▴

#3208 Wrong MultiMeasureRest glyph

Fixed
Malte Meyn
Fixed_2_21_0 (565)
Enhancement
2018-01-22
2013-02-27
Anonymous
No

Issue 3208: compressed MMRs choose correct glyphs

usable-duration-logs now affects only the choice of glyph for the
representation of a single measure. For multiple measures, glyphs for
longer rests up to maxima are used.

This is a second attempt to make it work and has little to do with my
first attempt at https://codereview.appspot.com/333340043 Therefore I
created a new Rietveld issue.

Also the vertical positioning of half and shorter rest glyphs in MMRs
now is handled correctly. BUT: this breaks make check because of a
different positioning of breve rests in TabStaffs. For details see
discussion below.

http://codereview.appspot.com/335410043

Originally created by: colingh...@gmail.com

Thomas Morley reported here:

http://lists.gnu.org/archive/html/bug-lilypond/2013-02/msg00180.html

as follows:

With measures longer than two whole notes LilyPond chooses different
glyphs for MultiMeasureRest.

\version "2.17.12"

\new Staff {
  \compressFullBarRests

  \time 7/4
  R1*7/4
  R1*7/4*2

  \break

  \time 9/4
  R1*9/4
  R1*9/4*2
  \break

  \time 18/4
  R1*18/4
  R1*18/4*2
}

Discussion on the user-list:
http://lilypond.1069038.n5.nabble.com/Glyph-for-longer-MultiMeasureRest-td141438.html

According to Gould LilyPond's default seems to be correct.
Werner objects.

At least there's need for discussion, I think.

Attached an image showing "LilyPond's default" vs "Correct?"

Regards,
  Harm

1 Attachments
mmr-02.png

Related

Issues: #3208
Issues: #5258

Discussion

<< < 1 2 3 (Page 3 of 3)

  • Anonymous

    Anonymous - 2018-01-16
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,4 +1,19 @@
-*Originally created by:* *anonymous
+Issue 3208: compressed MMRs choose correct glyphs
+
+usable-duration-logs now affects only the choice of glyph for the
+representation of a single measure. For multiple measures, glyphs for
+longer rests up to maxima are used.
+
+This is a second attempt to make it work and has little to do with my
+first attempt at https://codereview.appspot.com/333340043 Therefore I
+created a new Rietveld issue.
+
+Also the vertical positioning of half and shorter rest glyphs in MMRs
+now is handled correctly. BUT: this breaks make check because of a
+different positioning of breve rests in TabStaffs. For details see
+discussion below.
+
+http://codereview.appspot.com/335410043

 *Originally created by:* [colingh...@gmail.com](http://code.google.com/u/103174888511674413504/)
    • Patch: review --> countdown
     

  • Anonymous

    Anonymous - 2018-01-16

    Patch on countdown for Jan 19th.

     

  • Anonymous

    Anonymous - 2018-01-19
    • Patch: countdown --> push
     

  • Anonymous

    Anonymous - 2018-01-19

    Patch counted down - please push.

     

  • Malte Meyn

    Malte Meyn - 2018-01-22
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     

  • Malte Meyn

    Malte Meyn - 2018-01-22

    commit 600c6f57051966a21ff55a3feabad1d57efd9ee0
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Sat Jan 13 01:30:39 2018 +0100

    Issue 3208: compressed MMRs choose correct glyphs

usable-duration-logs now affects only the choice of glyph for the
representation of a single measure. For multiple measures, glyphs for
longer rests up to maxima are used.

Also the vertical positioning of half and shorter rest glyphs in MMRs
now is handled correctly.
     
<< < 1 2 3 (Page 3 of 3)