LilyIssues / Issues / #3134 Patch: Removes the translate_axis call from axis-group-interface outside-staff positioning.

Google Importer - 2013-03-05

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: passes make, make test and a full make doc. Reg test diffs here - https://www.yousendit.com/download/UVJqTkF0NEhCSnBWeHNUQw

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-08

Originally posted by: pkx1...@gmail.com

Patch on countdown for 11 March - 19:00 GMT

Labels: -Patch-review Patch-countdown

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-10

Originally posted by: k-ohara5...@oco.net

As noted in comment #48 above, some problems appeared around patch set 12 or 13.
InstrumentNames (that go to the left of the staves) and TupletNumbers are misplaced.

I haven't yet figured out enough to make any useful comment on Rietveld, but don't accidentally push this patch until the problems are fixed.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-11

Originally posted by: pkx1...@gmail.com

Keith has comments

Labels: -Patch-countdown Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-13

Originally posted by: mts...@gmail.com

Creates outside-staff-interface

http://codereview.appspot.com/7185044

Labels: -Patch-needs_work Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-13

Originally posted by: pkx1...@gmail.com

oo.. not sure what you did but it hung my VM running LilyDev during Make check.

I don't have time right now to dig deeper, but I will retry it later on this evening when I get back.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-13

Originally posted by: m...@mikesolomon.org

Odd...mine went through ok with two visual regtest changes.
It could be an indeterministic infinite loop or some sort of memory problem...
I'll rerun the regtests to see if it hangs. If it doesn't assume that it clears on my machine.
Thanks very much for your help with this - if it is indeterministic, your info will be the only thing that'll allow me to debug the patch :-/

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-13

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: passes make, make test and a full make doc.

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-13

Originally posted by: pkx1...@gmail.com

Attached reg tests

Screenshot%20-%20130313%20-%2021%3A58%3A47.jpg

Screenshot%20-%20130313%20-%2022%3A00%3A19.jpg

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-14

Originally posted by: pkx1...@gmail.com

Mike, after a very cursory check on my VM Host system after the LilyDev hang, I am certain it was a problem with Vbox itself not the patch. As on my Linux Host server, syslog was showing me traces/timeouts for AioMGR which is vBox specific. I normally use KVM than VBOX as it is a bit faster for Linux VMs and in terms of compiling LP Doc gives me about 20% quicker compiling times, which on 20 minutes I guess isn't that much but when 3 patches all need testing and full doc compiles at once it does add up. However vBOX has a nicer UI for when I want to use multiple VMs (for work stuff) Anyway, thought I'd let you know.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-17

Originally posted by: pkx1...@gmail.com

Patch on countdown for March 20th - 19:00 GMT

Labels: -Patch-review Patch-countdown

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-20

Originally posted by: pkx1...@gmail.com

patch counted down please push

Labels: -Patch-countdown Patch-push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-20

Originally posted by: mts...@gmail.com

Before I push this sucker, if I do, we are committing ourselves to pushing 2.18 until at least late July (unless all bugs surface fast). It is part of my work towards good cross-staff skylines. I'm gonna wait a couple more days to hear more from people - we've been talking a lot about 2.18. What I can say is that, if I push this, this'll be my last gimungous patch before 2.18 unless 2.18 takes forever. I'd time my next one for 2.19.1.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-20

Originally posted by: dak@gnu.org

> What I can say is that, if I push this, this'll be my last gimungous patch before 2.18 unless 2.18 takes forever.

I think either this preparatory patch should be in 2.18 along with the followup work based on it, or both should be out in a separate branch to be merged afterwards. But taking the pain without the gain for 2.18 does not appear to make sense.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-21

Originally posted by: mts...@gmail.com

There's no way that the follow-up work based on this will make it into 2.18, or perhaps even 2.20 or 2.22 for that matter.

This vertical spacing project is huge - it started with the first skyline patch, then there is:

-) this current one
-) a better pure approximation of outside-staff grobs that do not implement side-position-interface (slur, tuplet bracket, etc.) [easy]
-) the strategic flushing and recalculating of pure heights of vertical alignments [hard]
-) the creation of several stub grobs for cross-staff objects [hard]

I try to break it up into chunks that already have a tangible, positive effect on the code base and are not just internal reorganizations.

Here, there are two immediate benefits to users:
1) a clarification of what grobs go outside the staff via outside-staff-interface.
2) better placement of scripts on cross-staff grobs (check out fingering-cross-staff.ly).

Granted, these two benefits are not earth shattering. However, it is the best breaking point I can make in my thinking before I go forward.

So, to sum up, it is impossible to get everything in before 2.18. However, had I held myself to the standard of finishing up the project before pushing any of it to master, we wouldn't have the skyline spacing now. So I think it's OK to push clear intermediary stages that have loose ends wrapped up and have a tangible (albeit small in this case) benefit to LilyPond.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-21

Originally posted by: dak@gnu.org

> There's no way that the follow-up work based on this will make it into 2.18, or perhaps even 2.20 or 2.22 for that matter.

Then the best place for it is right after a stable release.

> 1) a clarification of what grobs go outside the staff via outside-staff-interface.

It would appear that this change could get factored out and provided separately if it was considered important enough for end users. Getting a stable release out at some point of time is important to end users. Balancing conflicting goals might make for some redundant work, yes.

> However, had I held myself to the standard of finishing up the project before pushing any of it to master, we wouldn't have the skyline spacing now.

Reality check: the skyline spacing was developed in a separate branch, and it was committed into the staging branch and released as 2.17.1 three days after the release of 2.16.0. So that does not exactly make a strong case for trying to fit this patch into 2.18.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-21

Originally posted by: mts...@gmail.com

That's why I'm asking about a time frame. If we think a stable release is possible in 3-4 months, I'm OK holding off. Anything longer and it's gonna be a lot of lost time for me rebasing and refactoring code. So if we can commit to the 3-4 month timeframe with only bugfixes to current master, I'm OK with that. In that case, we should tweak the countdowns so that there is Patch push 2.17 and Patch push 2.19 so that the review process can continue to go on but we know what can go in current master and what needs to wait.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-21

Originally posted by: dak@gnu.org

My own impression is that 2.18 in a two-month frame is feasible. I am not committing to participating with planning and policy setting until I am back from my vacation at April 1st, and planning and policy setting are not my strong suit, anyway. They are not in my job description, but of course that does not stop them from having an impact. It is clear that we have missed the deadline for making dependable plans sufficiently far in advance for developers to be able to adapt to them.

So if you want to give the decision-making the time to catch up with realities, this will keep this work for at least three more weeks in a branch before we even know what the decision will actually be. Somewhat less if someone other than myself tries drafting proposals etc, but since I will likely be responsible for most of the stable branch creation and maintenance, it might make sense if I am not just an observer to the process.

That's how I see the situation at the moment, and whether you see it in the same way or not and what you want to do or see done about it: right now it's your own call to make.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-21

Originally posted by: mts...@gmail.com

Two months is fine. Let's all make an effort, then, to only be pushing bug fixes and definitely no new enhancements (i.e. repeat slurs, Ferneyhough hairpins etc.).

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-21

Originally posted by: dak@gnu.org

Depends somewhat on the enhancements. If they have straightforward interfaces likely to stay and don't interfere with existing operations... I have not looked at the implementations so far, but with regard to the expected shakeout time until a stable release is not impacted, I'd estimate the hairpins to have a shorter impact period than the repeat slurs.

But yes, this is definitely a good time to focus on bug fixes that can be addressed without architectural upheavals.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-26

Originally posted by: pkx1...@gmail.com

patch counted down please push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-28

Originally posted by: mts...@gmail.com

Rebase off of current master.

http://codereview.appspot.com/7185044

Labels: -Patch-push Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-03-28

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: passes make, make test and a full make doc.

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-02

Originally posted by: pkx1...@gmail.com

Patch on Countdown for April 5th - 19:00 GMT

Labels: -Patch-review Patch-countdown

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-02

Originally posted by: janek.li...@gmail.com

If i understand the discussion about stable release correctly, this patch isn't supposed to go to countdown, but is waiting until after 2.18.

Labels: -Patch-countdown Patch-waiting

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Patch: Removes the translate_axis call from axis-group-interface...

Issue Tracker for LilyPond

Searches

Help

#3134 Patch: Removes the translate_axis call from axis-group-interface outside-staff positioning.

Discussion