LilyIssues / Issues / #3037 The end of a ligature bracket doesn't appear at the start of a line

#3037 The end of a ligature bracket doesn't appear at the start of a line

Status: Verified

Owner: nobody

Labels: Fixed_2_17_11 (21)

Needs:

Patch:

Type: Ugly

Updated: 2013-02-11

Created: 2012-12-17

Creator: Anonymous

Private: No

Originally created by: *anonymous

Originally created by: colingh...@gmail.com
Originally owned by: benko....@gmail.com

Ben Rudiak-Gould reported here:

http://lists.gnu.org/archive/html/bug-lilypond/2012-12/msg00064.html

as follows:

% The end of the ligature bracket is not printed
\version "2.17.8"
{ \[ c'1 \break d'1 \] }

1 Attachments

bug.preview.png

Related

Discussion

Google Importer - 2012-12-18

Originally posted by: mts...@gmail.com

Sets bracket-visibility to true for ligature brackets

http://codereview.appspot.com/6946077

Labels: Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-12-18

Originally posted by: mts...@gmail.com

Sets bracket-visibility to true for ligature brackets

http://codereview.appspot.com/6946077

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-12-18

Originally posted by: dak@gnu.org

Patchy the autobot says: passes tests. The regtest input/regression/ambitus-with-ligature.ly now shows both a ligature as well as a ligature bracket. Is this effect intentional?

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-12-20

Originally posted by: ColinPKC...@gmail.com

(No comment was entered for this change.)

Labels: -Patch-review Patch-countdown
Owner: mts...@gmail.com

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-12-21

Originally posted by: benko....@gmail.com

David: the effect is probably not intended, but implicitly required by _not_ \remove'ing "Ligature_bracket_engraver". I understand less and less why brackets were seen at all so long.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-12-23

Originally posted by: ColinPKC...@gmail.com

Counted down to 20121223, please push.

Labels: -Patch-countdown Patch-push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-01-03

Originally posted by: benko....@gmail.com

ping

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-01-09

Originally posted by: mts...@gmail.com

Pushed as [r2502db9d63fd5c0ac2171e3c70943510d4456746].

Labels: Fixed_2_17_9
Status: Fixed

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-01-09

Originally posted by: mts...@gmail.com

(No comment was entered for this change.)

Labels: -Fixed_2_17_9 Fixed_2_17_10

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-01-13

Originally posted by: benko....@gmail.com

make a regtest more reasonable

follows up [r2502db9d63fd5c0ac2171e3c70943510d4456746] for issue 3037

http://codereview.appspot.com/7103052

Labels: -Patch-push Patch-new
Owner: benko....@gmail.com
Status: Started

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-01-13

Originally posted by: pkx1...@gmail.com

Pass Make, Make check and a full make doc.

Reg test attached

Labels: -Fixed_2_17_10 -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-01-13

Originally posted by: pkx1...@gmail.com

(No comment was entered for this change.)

Screenshot%20-%20130113%20-%2023%3A08%3A24.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-01-15

Originally posted by: ColinPKC...@gmail.com

(No comment was entered for this change.)

Labels: -Patch-review Patch-countdown

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-01-23

Originally posted by: dak@gnu.org

This should better have been an issue of its own rather than coattailing on an already fixed issue since regtest and main issue have been committed to different versions. That makes handling the issues properly rather hard to do.

At any rate, please push.

Labels: -Patch-countdown Patch-push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-01-23

Originally posted by: benko....@gmail.com

agreed, sorry.

pushed to staging as
[r2502db9d63fd5c0ac2171e3c70943510d4456746]

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-09

Originally posted by: dak@gnu.org

No, the followup patch is not [r2502db9d63fd5c0ac2171e3c70943510d4456746]. That was the original one from Mike.

This, in contrast, was
commit [r89cb4a2432c55f2b28ef4b7c976e4d47b6bb4195]
Author: Benkő Pál <benko.pal@gmail.com>
Date: Thu Jan 10 23:00:25 2013 +0100

issue 3037: follow up [r2502db9d63fd5c0ac2171e3c70943510d4456746]

It would appear to have been included in 2.17.11. Please try not to make life of the Bug Squad harder by providing false information and omitting to update the status of an issue.

And something might be said for more descriptive commit messages as well.

Labels: -Patch-push Fixed_2_17_11

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-10

Originally posted by: mts...@gmail.com

(No comment was entered for this change.)

Status: Fixed

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-02-11

Originally posted by: Elu...@gmail.com

(No comment was entered for this change.)

Status: Verified

If you would like to refer to this comment somewhere else in this project, copy and paste the following link: