Menu
▾
▴
#2533 Patch: line_count fixes
Originally created by: *anonymous
Originally created by: benko....@gmail.com
Originally owned by: benko....@gmail.com
line_count fixes
1. implementation does not assume staff centred at zero
2. where used for determining whether something falls on a line,
use Staff_symbol_referencer::on_line or on_staff_line
3. where used for determining whether something is within staff or not,
use Staff_symbol_referencer::staff_span
Discussion
Originally posted by: benko....@gmail.com
regression test changes are explained in comments on the patch.
during testing I found a bug in the test-check framework, I'm afraid:
in the summary page slur-symmetry-1 was reported, but the corresponding png files, though named correctly as slur-symmetry-1, were the same as those of slur-symmetry (i.e. in 6/8).
Owner: benko....@gmail.com
Originally posted by: pkx1...@gmail.com
Patchy has no complaints. Most reg tests are fine, have attached the ones that have 'significant' changes - that doesn't mean they are bad but just that have changed more than a few pixels, so to speak.
Labels: -Patch-new Patch-review
Originally posted by: benko....@gmail.com
sorry, I forgot to attach the mainline version of the enhanced non-centered-bar-lines test:
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: benko....@gmail.com
(No comment was entered for this change.)
Labels: -Patch-countdown Patch-needs_work
Originally posted by: benko....@gmail.com
line_count fixes
1. implementation does not assume staff centred at zero
2. where used for determining whether something falls on a line,
use Staff_symbol_referencer::on_line or on_staff_line
3. where used for determining whether something is within staff or not,
use Staff_symbol_referencer::staff_span
http://codereview.appspot.com/6211047
Labels: -Patch-needs_work Patch-new
Originally posted by: benko....@gmail.com
pre-patch versions of modified regression tests, to see repeat signs in non-standard staves.
Originally posted by: ColinPKC...@gmail.com
Patchy the autobot says: LGTM.
Labels: -Patch-new Patch-review
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: benko....@gmail.com
staff-ledger-positions didn't improve
Labels: -Patch-countdown Patch-needs_work
Originally posted by: benko....@gmail.com
line_count fixes
1. implementation does not assume staff centred at zero
2. where used for determining whether something falls on a line,
use Staff_symbol_referencer::on_line or on_staff_line
3. where used for determining whether something is within staff or not,
use Staff_symbol_referencer::staff_span
http://codereview.appspot.com/6211047
Labels: -Patch-needs_work Patch-new
Originally posted by: benko....@gmail.com
pre-patch version of modified regtest zero-staff-space.ly attached.
for whatever reason the changes of staff-line-positions and staff-ledger-positions don't appear in the regtest comparison output, but I verified manually that they change.
Originally posted by: ColinPKC...@gmail.com
Patchy the autobot says: LGTM. Many changes with slurs, but no obvious negatives. Breathing-sign-custom mnoves the time sig and clef into the staff. Expected changed from adding rep[eats.
Labels: -Patch-new Patch-review
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: benko....@gmail.com
line_count fixes
1. implementation does not assume staff centred at zero
2. where used for determining whether something falls on a line,
use Staff_symbol_referencer::on_line or on_staff_line
3. where used for determining whether something is within staff or not,
use Staff_symbol_referencer::staff_span
http://codereview.appspot.com/6211047
Labels: -Patch-countdown Patch-new
Originally posted by: ColinPKC...@gmail.com
Patchy the autobot says: LGTM. Same changes in regtests: Many changes with slurs, but no obvious negatives. Breathing-sign-custom mnoves the time sig and clef into the staff. Expected changes from adding repeats.
Labels: -Patch-new Patch-review
Originally posted by: benko....@gmail.com
line_count fixes
1. implementation does not assume staff centred at zero
2. where used for determining whether something falls on a line,
use Staff_symbol_referencer::on_line or on_staff_line
3. where used for determining whether something is within staff or not,
use Staff_symbol_referencer::staff_span
http://codereview.appspot.com/6211047
Labels: -Patch-review Patch-new
Originally posted by: ColinPKC...@gmail.com
Patchy the autobot says: passes tests.
Labels: -Patch-new Patch-review
Originally posted by: benko....@gmail.com
line_count fixes
1. implementation does not assume staff centred at zero
2. where used for determining whether something falls on a line,
use Staff_symbol_referencer::on_line or on_staff_line
3. where used for determining whether something is within staff or not,
use Staff_symbol_referencer::staff_span
http://codereview.appspot.com/6211047
Labels: -Patch-review Patch-new
Originally posted by: ColinPKC...@gmail.com
Patchy the autobot says: LGTM. Same set of changes as before, mainly involving slurs and ties, but the changes don't seem negative to me.
Labels: -Patch-new Patch-review
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: ColinPKC...@gmail.com
Counted down to 20120531, please push
Labels: -Patch-countdown Patch-push
Originally posted by: benko....@gmail.com
pushed to staging as [r2a872121379fffe7b1cd5d23048b7ea04b4d1f68]
Originally posted by: benko....@gmail.com
[r2a872121379fffe7b1cd5d23048b7ea04b4d1f68] reached master
Status: Fixed
Originally posted by: Elu...@gmail.com
(No comment was entered for this change.)
Status: Verified