LilyIssues / Issues / #2245 wrong/inconsistent placement of lyrics and dynamics under suspended notes

Google Importer - 2012-01-23

Originally posted by: thomasmo...@gmail.com

As remarked in the threads above the same appears with DynamicText. But not with Script or TextScript. Attached an image wich shows the default and a corrected version, using the function created by David Nalesnik.

Cheers,
Harm

atest-09.ly

atest-09.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-01-23

Originally posted by: janek.li...@gmail.com

nice example, thanks!

Summary: wrong/inconsistent placement of lyrics and dynamics under suspended notes

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-06-13

Originally posted by: janek.li...@gmail.com

Issue 1911 has been merged into this issue.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-04-09

Originally posted by: Karol.Ma...@gmail.com

This is an updated version of function written by David Nalesnik. Now you can assign dynamic-script to rest.

atest-10.ly

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-28

Originally posted by: janek.li...@gmail.com

(No comment was entered for this change.)

Blockedon: lilypond:3979

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-29

Originally posted by: janek.li...@gmail.com

(No comment was entered for this change.)

Blocking: lilypond:3979

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-29

Originally posted by: janek.li...@gmail.com

(No comment was entered for this change.)

Blockedon: -lilypond:3979

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-29

Originally posted by: janek.li...@gmail.com

Issue 2245: always align dynamics and lyrics on "main" notehead

Until now, LyricTexts and DynamicTexts had their X-parents set to
the first NoteHead in the NoteColumn. This resulted in inconsistent
alignment - placement of lyrics and dynamics depended on the order
of notes in the input:

% this was aligned differently
{ <f' g'>1\p <g' f'>\p }
\addlyrics { la la }

By using NoteColumns themselves as the X-parents, we make sure that
the input order won't matter. Since the NoteColumn contains all NoteHeads
(including suspended ones, which usually should be ignored when aligning),
we add a function for calculating X-extent of the "main" part of the
NoteColumn, i.e. without suspended NoteHeads.

http://codereview.appspot.com/108270044

Labels: Patch-new
Owner: janek.li...@gmail.com
Status: Started

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-29

Originally posted by: janek.li...@gmail.com

Actual patch - always align dynamics and lyrics on "main" notehead

http://codereview.appspot.com/108270044

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-29

Originally posted by: janek.li...@gmail.com

(No comment was entered for this change.)

Labels: -Needs-design

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-30

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: This produces a seg fault during make doc for ancient-headword.ly

Labels: -Patch-new Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-30

Originally posted by: janek.li...@gmail.com

Ah, i see what the problem is - will fix today. Thanks!

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-30

Originally posted by: janek.li...@gmail.com

don't segfault when there are no stems.

http://codereview.appspot.com/108270044

Labels: -Patch-needs_work Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-30

Originally posted by: pkx1...@gmail.com

Passes make, make check and a full make doc.

Reg test diff attached.

Labels: -Patch-new Patch-review

Screenshot.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-06-30

Originally posted by: janek.li...@gmail.com

This is expected (as this issue depends on 3978 and the tested patch included that patch). Thanks for testing!

Blockedon: lilypond:3978

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-07-01

Originally posted by: janek.li...@gmail.com

(No comment was entered for this change.)

2245-example-for-mark.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-07-01

Originally posted by: janek.li...@gmail.com

(No comment was entered for this change.)

Blocking: lilypond:3521

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-07-04

Originally posted by: pkx1...@gmail.com

Patch on countdown for July 8th 2014

Labels: -Patch-review Patch-countdown

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-07-07

Originally posted by: pkx1...@gmail.com

Patch counted down - please push

Labels: -Patch-countdown Patch-push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-07-08

Originally posted by: janek.li...@gmail.com

Pushed as

commit [r59a842eba0f7ad78289a58a7dfa8fa786cdf11ed]
Author: Janek Warchoł <lemniskata.bernoullego@gmail.com>
Date:   Wed Mar 27 17:20:03 2013 +0100

    Issue 2245: always align dynamics and lyrics on "main" notehead

    Until now, LyricTexts and DynamicTexts had their X-parents set to
    the first NoteHead in the NoteColumn. This resulted in inconsistent
    alignment - placement of lyrics and dynamics depended on the order
    of notes in the input:

    % this was aligned differently
    { <f' g'>1\p <g' f'>\p }
    \addlyrics { la la }

    By using NoteColumns themselves as the X-parents, we make sure that
    the input order won't matter. Since the NoteColumn contains all NoteHeads
    (including suspended ones, which usually should be ignored when aligning),
    as well as Flags and some other objects, we cannot use its X-extent directly -
    instead, we add a function for calculating X-extent of the "main" part of the
    NoteColumn, i.e. X-extent of the non-suspended NoteHeads (represented by the
    NoteHead furthest away from the stem).

Labels: -Patch-push Fixed_2_19_10
Status: Fixed

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-07-18

Originally posted by: fedel...@gmail.com

(No comment was entered for this change.)

Status: Verified

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

wrong/inconsistent placement of lyrics and dynamics under suspended notes

Issue Tracker for LilyPond

Searches

Help

#2245 wrong/inconsistent placement of lyrics and dynamics under suspended notes

Related

Discussion