LilyIssues / Issues / #2109 do not tinker with the position of a pitched rest

Google Importer - 2011-12-15

Originally posted by: lilypond...@gmail.com

Patchy the autobot says: patch does not apply to current master

Labels: Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-12-18

Originally posted by: pkx1...@gmail.com

(No comment was entered for this change.)

Status: Started

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-12-21

Originally posted by: benko....@gmail.com

patch updated

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-12-21

Originally posted by: benko....@gmail.com

(No comment was entered for this change.)

Labels: -Patch-needs_work Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-12-21

Originally posted by: lilypond...@gmail.com

Patchy the autobot says: LGTM.

Labels: Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-12-22

Originally posted by: ColinPKC...@gmail.com

(No comment was entered for this change.)

Labels: -Patch-review Patch-countdown
Owner: benko....@gmail.com

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-12-24

Originally posted by: ColinPKC...@gmail.com

Counted down to 20111224, please push

Labels: -Patch-countdown Patch-push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-01-03

Originally posted by: janek.li...@gmail.com

pushed as [r9f24e79a945ec4ab000d3e09ff2d2ac8208e2246]
Sorry for the delay and many thanks for the patch, Pal!

Labels: -Patch-push
Status: Fixed

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-01-24

Originally posted by: Elu...@gmail.com

this issue cannot be verified since there are underlying problems with the positioning of ledger lines and pitched rests - see https://code.google.com/p/lilypond/issues/detail?id=2249

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-01-25

Originally posted by: pkx1...@gmail.com

https://code.google.com/p/lilypond/issues/detail?id=2249

Is now marked as invalid. So can we verify this?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-02-01

Originally posted by: Elu...@gmail.com

I'd say this too is "invalid" or "needs evidence" since "if I extend the staff by a line..." (http://codereview.appspot.com/5434061/) moves the misplaced rests to the right position but also the right placed to a wrong position.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-02-01

Originally posted by: benko....@gmail.com

> I'd say this too is "invalid" or "needs evidence" since "if I extend the staff by a line..." (http://codereview.appspot.com/5434061/) moves the misplaced rests to the right position but also the right placed to a wrong position.

explicitly placed rests are now really at the user-specified height (which may definitely be right or wrong); do you mean something else?
could you provide a tiny example how it looked before and after this patch?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-02-02

Originally posted by: Elu...@gmail.com

it is too confusing with these 5, 6 or 7 lines - I simply attach 2 files with the output of version 2.15.1 and 27:

may somebody else try to tell exactly what is wrong or not!

2.15.%201%20issue%202109.png

2.15.27%20issue%202109.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-02-02

Originally posted by: k-ohara5...@oco.net

Assuming the input code for comment 13 was
\new Staff \with {
\override StaffSymbol #'line-count = 6 % also 5, and 7
} \relative f { \clef alto b2 b\rest c c\rest d d\rest e e\rest }

old LilyPond placed pitches rests correctly only when the pitch lies on a line in a default staff, varying the relation between pitch- and rest-location.

new LilyPond places them in a constant relation to the pitch, so they are correct when the pitch lies on a line in the staff actually being drawn

The new behavior is probably a bit easier to use.

Problems
1) The regression test added by the patch, however, produces recognizable rests with the old code, and what appear to be errors with the new code. Pál, pleas change this so the regression test shows desired output. Otherwise, we will be confused in six months and might reverse your change trying to 'fix' the output of the regtest.

2) The bug report gives no description of the desired output after the change, just a link to a patch. I think the bug squad is asked to mark these Validated as soon as the change appears in a release, without reviewing the change. Likewise I don't bother reviewing the code in these cases.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-02-02

Originally posted by: benko....@gmail.com

the regression test demonstrates that pitched rests were not always at the prescribed vertical position and now they are; default whole rests are one line off, but correctness didn't change with my patch.

note that setting line-count to an even value puts the clef into a space, not onto a line, so I think it's of use only in percussion staves.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-02-02

Originally posted by: Elu...@gmail.com

maybe a little note/warning/"known issue" in the docs would reduce more confusion:

in NR after:

"1.2.2 Writing rests
Rests are entered as part of the music in music expressions.
Rests
…

To explicitly specify a rest's vertical position, write a note followed by \rest. A rest of the duration of the note will be placed at the staff position where the note would appear.
…
…
…
Known issues and warnings"

we could add

"When using pitched half or full rests special attention is required to ascertain their typical behavior of lying or hanging on a staff line."

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-02-02

Originally posted by: k-ohara5...@oco.net

The regression test 'rest-on-nonstandard-staff.ly' has input indicating
half-rest half-rest | whole-rest | whole-rest |
in parallel in three different staves.

On a /standard/ staff, whole rests hang below a line, half rests sit atop a line. Interpreting the LilyPond output according to this background,

version 2.14.2 output looks like
half half | whole | whole
half half | whole | whole
half half | whole | whole

version 2.15.27 output looks like
half half | whole | whole
ugly-whole half | ugly-half | whole
half ugly-whole | whole | ugly-half

rest-on-nonstandard-staff.after.pdf

rest-on-nonstandard-staff.before.pdf

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-02-02

Originally posted by: benko....@gmail.com

ah, you compare _those_ two versions. I attached the state between d10ec4f5 and 9f24e79a. look how the middle staff is broken; I tracked down the cause to the obviously correct change to Staff_symbol::line_count in d10ec4f5.

note that 2.14 made pitched rests appear not exactly at the required height in the third staff: the half looks like a2\rest, the whole as f1\rest. d10ec4f5 made pitched rests in the second staff look like those too. 9f24e79a made pitched rests appear at the required position (even if it's bad); I'm working on non-pitced rests, stay tuned.

rest-on-nonstandard-staff.between.pdf

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-02-03

Originally posted by: dak@gnu.org

The ongoing discussion does not appear to jibe with the label "Fixed". Changing to "Started".

Status: Started

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-02-04

Originally posted by: benko....@gmail.com

shall I open a new rietveld issue for the new patch or use the old one?
http://codereview.appspot.com/5434061/

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-02-06

Originally posted by: benko....@gmail.com

I messed up the uploading, so it's the same Rietveld issue but a new tracker issue:
https://code.google.com/p/lilypond/issues/detail?id=2300

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2012-02-08

Originally posted by: janek.li...@gmail.com

(No comment was entered for this change.)

Mergedinto: 2300
Status: Duplicate

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

do not tinker with the position of a pitched rest

Issue Tracker for LilyPond

Searches

Help

#2109 do not tinker with the position of a pitched rest

Related

Discussion