Menu
▾
▴
#2026 Make markup utility definitions available via new (scm markup-utility-defs) scheme module
Accepted
nobody
None
abandoned
Maintainability
2015-10-22
2011-11-06
Anonymous
No
Originally created by: *anonymous
Originally created by: ianhuli...@gmail.com
Originally owned by: ianhuli...@gmail.com
The interface between the markup utility and the rest of the scheme code is messy, and needs to be migrated from its current half-way house solution (moving some markup code to scm/markup-modules.scm and loading this first in lily.scm's load list) to a proper module.
This affects the following scheme files.
scm/lily.scm
scm/markup.scm (will be gutted)
scm/markup-macros.scm (will be deleted)
scm/define-markup-commands.scm
scm/define-woodwind-diagrams.scm
scm/display-woodwind-diagrams.scm
scm/fret-diagrams.scm
scm/harp-pedals.scm
scm/tablature.scm
New file
scm/markup-utility-defs.scm
Bug Squad: Criteria for verifying this change - passes reg tests and does no harm when running with Guile V1.8.*,
Originally posted by: ianhuli...@gmail.com
Comments from David on Rietveld, http://codereview.appspot.com/5464045/, these need resolving before pushing.
Labels: -Patch-push Patch-needs_work
Originally posted by: ianhuli...@gmail.com
A modified patch is now available. Please note it's a new Rietveld issue number.
It's http://codereview.appspot.com/5504107
Passes make and reg-tests locally.
Ian
Labels: -Patch-needs_work Patch-review
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: ColinPKC...@gmail.com
Counted down to 20120105, please push.
Labels: -Patch-countdown Patch-push
Originally posted by: ianhuli...@gmail.com
Pushed to staging,
ian@nanny-ogg ~/src/lilypond/build (T2026)$ git push origin HEAD:staging
Counting objects: 41, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (22/22), done.
Writing objects: 100% (22/22), 31.82 KiB, done.
Total 22 (delta 18), reused 0 (delta 0)
To ssh://ian_hulin@git.sv.gnu.org/srv/git/lilypond.git
3af42c0..dc15f51 HEAD -> staging
Labels: -Patch-push
Status: Fixed
Originally posted by: ianhuli...@gmail.com
(No comment was entered for this change.)
Blocking: -1686
Originally posted by: ianhuli...@gmail.com
Caused docs build to fail in Documentation/ly-examples/chart.ly.
Apparently fails in a markup? call. I had added code to lily.scm to handle throws from the markup code and this showed up as 'unbound variable empty-markup. Further fettling of the handling code and a change to using the detailed markup-thrower-typecheck for markup? showed the problem that the markup? predicate couldn't cope with processing a (0 . 0) pair.
It turns out we have had a lurking bug in define-markup-commands.scm caused by this
code:
(define-public (empty-markup)
(make-simple-markup ""))
This was working as long as we were basically turning a blind eye to throws in the run-time guile procedures in lily.scm. As soon as we started catching throws other than 'ly-failed-file, errors from this procedure surfaced. 'empty-markup' is used in lots of places in chord-processing fretboard and tablature code scheme code. This is fixed if we move the definition of the \null markup to the before the empty-markup declaration and change empty-markup to
(define-public (empty-markup)
make-null-markup))
I've tested this with a minimal changes patch on a branch from master which I've attached. It's built the docs successfully and run reg-tests OK. I've attached a patch-file.
I'll merge these changes into my local T2026 branch and upload an amended patch-set to Rietveld for review.
Cheers, Ian
Labels: Patch-needs_work
Status: Started
Originally posted by: dak@gnu.org
Given the scope of this patch series and the history of applying it, wouldn't it make sense to check a doc build before pushing to staging?
Originally posted by: dak@gnu.org
(No comment was entered for this change.)
Blocking: 1826
Originally posted by: ma...@gregoriana.sk
From bug-lilypond, reported by Robin Bannister
http://lists.gnu.org/archive/html/bug-lilypond/2012-02/msg00029.html
In https://code.google.com/p/lilypond/issues/detail?id=2026#c32 Ian Hulin wrote:
This is fixed if we move the definition of the \null markup to the before the empty-markup declaration and change empty-markup to
(define-public (empty-markup)
make-null-markup))
...
It's built the docs successfully and run reg-tests OK.
OK, the docs say \null markup is an "empty markup", merely a single point, but it has _position_, which empty-markup does not. The following snippet demonstrates this difference: %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
offset = \markup \translate #'(9 . 9) "offset"
\markup \line { "concat with empty-markup:" \box \concat { \empty-markup \offset } " concat with null markup: "\box \concat { \null \offset }
}
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
Cheers, Robin
Originally posted by: ianhuli...@gmail.com
Punting this one into long grass rather than hold up Guile V2 migration.
Marking Patch-abandoned and closing
Ian
Labels: -Patch-needs_work Patch-abandoned
Originally posted by: ianhuli...@gmail.com
(No comment was entered for this change.)
Blocking: -lilypond:1826
Diff:
Reverting the Status of this issue to Accepted, as the existing patch has been abandoned and there has been no further activity for almost 3 years.