Seg fault and 100% CPU when using \override Staff.StaffSymbol #'ledger-positions

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#1972 Seg fault and 100% CPU when using \override Staff.StaffSymbol #'ledger-positions

Status: Verified

Owner: nobody

Labels: fixed_2_15_16 (3)

Needs:

Patch:

Type: Crash

Updated: 2011-11-06

Created: 2011-10-16

Creator: Anonymous

Private: No

Originally created by: *anonymous

Originally created by: ColinPKC...@gmail.com

Reported by James Lowe:

% this produces a segfault
\version "2.15.13"
\relative c' {
\override Staff.StaffSymbol #'ledger-positions = #'(1)
c4
}

Discussion

Google Importer - 2011-10-16

Originally posted by: pkx1...@gmail.com

% this also produces stuck 100% CPU at 'Drawing systems...'

\version "2.15.13"
\relative c' {
\override Staff.StaffSymbol #'ledger-positions = #'(1 1 1)
f''4 a a,, f
}

% this works

\version "2.15.13"
\relative c' {
\override Staff.StaffSymbol #'ledger-positions = #'(1 2 1)
f''4 a a,, f
}

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-16

Originally posted by: k-ohara5...@oco.net

Clearly this is due to the change for issue 1193 so I've put a link here in a comment on Reitveld for that patch. We should have caught the infinite loop and null pointer in code review.

To revert commit d10ec4f5 for issue 1193, we will probably need to first revert my cleanup patch 97bc5c1e.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-17

Originally posted by: piersti...@gmail.com

I'll have a look at it, and add a warning or error messages in case something is strange.

Sorry for the naive assumption that people enter valid input.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-17

Originally posted by: piersti...@gmail.com

There is a patch at Rietveld: http://codereview.appspot.com/4974075/

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-17

Originally posted by: percival.music.ca@gmail.com

(No comment was entered for this change.)

Labels: Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-17

Originally posted by: percival.music.ca@gmail.com

Patch location: (newlines requried for now; please use our updated git-cl)

http://codereview.appspot.com/4974075/

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-17

Originally posted by: percival.music.ca@gmail.com

Patchy the autobot says: LGTM.

Labels: Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-18

Originally posted by: ColinPKC...@gmail.com

Keith has mentioned some concerns and suggestions on Rietveld.

Labels: -Patch-review Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-22

Originally posted by: piersti...@gmail.com

New patch on Rietveld

http://codereview.appspot.com/4974075/

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-22

Originally posted by: percival.music.ca@gmail.com

(No comment was entered for this change.)

Labels: -Patch-needs_work Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-23

Originally posted by: percival.music.ca@gmail.com

Patchy the autobot says: LGTM.

Labels: Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-23

Originally posted by: ColinPKC...@gmail.com

(No comment was entered for this change.)

Labels: -Patch-review Patch-countdown

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-24

Originally posted by: k-ohara5...@oco.net

Patchy the autobot said "LGTM" about a patch that doesn't compile.

But the error was trivial, and the fixed patch looks good to Keith the human.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-24

Originally posted by: percival.music.ca@gmail.com

hmm. I rewrote Patchy to raise exceptions about 24 hours ago, instead of relying on manually returning true or false. Hopefully that'll avoid similar problems in the future, although there's no guarantee of this.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-25

Originally posted by: ColinPKC...@gmail.com

Counteddown to 20111025

Labels: -Patch-countdown Patch-push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-10-25

Originally posted by: k-ohara5...@oco.net

pushed as commit 93078545

Labels: -Patch-push fixed_2_15_16
Status: Fixed

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2011-11-06

Originally posted by: PhilEHol...@googlemail.com

(No comment was entered for this change.)

Status: Verified

If you would like to refer to this comment somewhere else in this project, copy and paste the following link: