Menu

#1878 Add support for custom ledger positions, using two new staff-symbol properties

Verified
nobody
Enhancement
2011-09-27
2011-09-09
Anonymous
No

Originally created by: *anonymous

Originally created by: pkx1...@gmail.com
Originally owned by: janek.li...@gmail.com

http://codereview.appspot.com/4974075/

Discussion

  • Google Importer

    Google Importer - 2011-09-10

    Originally posted by: pkx1...@gmail.com

    passes make and reg tests

    Labels: -Patch-new Patch-review

     
  • Google Importer

    Google Importer - 2011-09-13

    Originally posted by: brownian.box@gmail.com

    why still new?

    Status: Accepted

     
  • Google Importer

    Google Importer - 2011-09-13

    Originally posted by: pkx1...@gmail.com

    The reason I changed it to new (and then to review 3 days ago!) was that it had no tracker and also had had no checks that I could see, so if I make the tracker issue 'patch-new' it shows up on the google tracker list for me to check.

    I don't mind devs jumping straight to patch-review but if they do that, I won't check a patch or may miss it if they need checking.

    We (well, some of us :) ) are trying to make sure that the Reitveld issues have a corresponding google tracker (because of the ease of searching compared to Rietveld).

    I have no simple way in Reitveld to let me know what is and what isn't new or needs review etc.

    Anyway this is now patch-review.

     
  • Google Importer

    Google Importer - 2011-09-14

    Originally posted by: ColinPKC...@gmail.com

    Corrections requesated; see Rietveld.

    Labels: -Patch-review Patch-needs_work

     
  • Google Importer

    Google Importer - 2011-09-14

    Originally posted by: ColinPKC...@gmail.com

    Corrections requesated; see Rietveld.

     
  • Google Importer

    Google Importer - 2011-09-24

    Originally posted by: percival.music.ca@gmail.com

    (No comment was entered for this change.)

    Labels: -Patch-needs_work Patch-review

     
  • Google Importer

    Google Importer - 2011-09-25

    Originally posted by: janek.li...@gmail.com

    pushed [rd10ec4f5a95d5b205da1bd73102697f8cc03b5b6]

    Labels: -Patch-review fixed_2_15_13
    Owner: janek.li...@gmail.com
    Status: Fixed

     
  • Google Importer

    Google Importer - 2011-09-27

    Originally posted by: brownian.box@gmail.com

    (No comment was entered for this change.)

    Status: Verified

     
Auth0 Logo