The reason I changed it to new (and then to review 3 days ago!) was that it had no tracker and also had had no checks that I could see, so if I make the tracker issue 'patch-new' it shows up on the google tracker list for me to check.
I don't mind devs jumping straight to patch-review but if they do that, I won't check a patch or may miss it if they need checking.
We (well, some of us :) ) are trying to make sure that the Reitveld issues have a corresponding google tracker (because of the ease of searching compared to Rietveld).
I have no simple way in Reitveld to let me know what is and what isn't new or needs review etc.
Anyway this is now patch-review.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Originally posted by: pkx1...@gmail.com
passes make and reg tests
Labels: -Patch-new Patch-review
Originally posted by: brownian.box@gmail.com
why still new?
Status: Accepted
Originally posted by: pkx1...@gmail.com
The reason I changed it to new (and then to review 3 days ago!) was that it had no tracker and also had had no checks that I could see, so if I make the tracker issue 'patch-new' it shows up on the google tracker list for me to check.
I don't mind devs jumping straight to patch-review but if they do that, I won't check a patch or may miss it if they need checking.
We (well, some of us :) ) are trying to make sure that the Reitveld issues have a corresponding google tracker (because of the ease of searching compared to Rietveld).
I have no simple way in Reitveld to let me know what is and what isn't new or needs review etc.
Anyway this is now patch-review.
Originally posted by: ColinPKC...@gmail.com
Corrections requesated; see Rietveld.
Labels: -Patch-review Patch-needs_work
Originally posted by: ColinPKC...@gmail.com
Corrections requesated; see Rietveld.
Originally posted by: percival.music.ca@gmail.com
(No comment was entered for this change.)
Labels: -Patch-needs_work Patch-review
Originally posted by: janek.li...@gmail.com
pushed [rd10ec4f5a95d5b205da1bd73102697f8cc03b5b6]
Labels: -Patch-review fixed_2_15_13
Owner: janek.li...@gmail.com
Status: Fixed
Originally posted by: brownian.box@gmail.com
(No comment was entered for this change.)
Status: Verified