Menu
▾
▴
#1790 Proper loglevels: cmd-line option --loglevel=NONE/ERROR/WARN/PROGRESS/INFO/DEBUG
Originally created by: *anonymous
Originally created by: pkx1... (code.google.com)@gmail.com
Originally owned by: reinhold... (code.google.com)@gmail.com
Proper loglevels: cmd-line option --loglevel=NONE/ERROR/WARN/PROGRESS/INFO/DEBUG
Allow the user to specify which messages (s)he wants to see on stderr:
The lilypond code basically stays the same, I only added a loglevel
global variable, which is used in the warning/error*/progress*/success
functions (ly:warning, ly:error, etc. in Scheme). If the proper level
is not set for a message, it is not printed.
There are only two larger changes:
-) Global var be_verbose_global replaced by loglevel (much finer-grained)
-) New functions (full)debug_output, which replaces code like:
if (be_verbose_global) {
progress_indication (...)
}
All changes were done to warn.cc and to the member of the Input class
(apparently, we have two parallel error-reporting "frameworks" in
lilypond...).
Note for all functions in warn.cc (not for the members of Input):
The debug_output function (and progress_indication and message) have
an optional argument to specify whether the output of the message
should always start on a new line or continue the previous output.
Documentation for this new feature is still missing (both in the AU
as well as in the CG)
Discussion
Originally posted by: pkx1... (code.google.com)@gmail.com
Passes make and reg test.
Labels: -Patch-new Patch-review
Originally posted by: pkx1... (code.google.com)@gmail.com
Sorry this is Rietveld issue
http://codereview.appspot.com/4822055/
Originally posted by: percival.music.ca@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-needs_work
Originally posted by: reinhold... (code.google.com)@gmail.com
(No comment was entered for this change.)
Labels: -Patch-needs_work Patch-new
Originally posted by: reinhold... (code.google.com)@gmail.com
(No comment was entered for this change.)
Status: Started
Originally posted by: pkx1... (code.google.com)@gmail.com
(No comment was entered for this change.)
Labels: -Patch-new Patch-needs_work
Originally posted by: reinhold... (code.google.com)@gmail.com
Why does that patch need work?
Originally posted by: pkx1... (code.google.com)@gmail.com
From Reitveld --snip--
Reinhold
¶
1 day, 4 hours ago
http://codereview.appspot.com/4822055/diff/18001/scripts/build/mf2pt1.pl
File scripts/build/mf2pt1.pl (right):
http://codereview.appspot.com/4822055/diff/18001/scripts/build/mf2pt1.pl#newc...
scripts/build/mf2pt1.pl:1: #!@PERL@
Apparently, I dit a git fetch, but didn't rebase that branch before uploading.
Please ignore all changes in this file...
--snip--
see the last line
?
This looked like you were going to do some 'stuff' to this patch.
If not, sorry.
James
Originally posted by: percival.music.ca@gmail.com
Thanks for checking, James. Reinhold's comment was actually announcing that he had *fixed* that problem, but the first two times I read his comment, I also thought he was just warning us that he had *noticed* a problem and was going to fix it later.
I'm moving it back to patch-review.
Labels: -Patch-needs_work Patch-review Priority-Medium
Originally posted by: reinhold... (code.google.com)@gmail.com
Pushed with commit [r86713eefa608f7dc738420ce0225c2a92c4539b2] (and the following)
Labels: -Patch-review fixed_2_15_9
Status: Fixed
Originally posted by: brownian.box@gmail.com
(No comment was entered for this change.)
Status: Verified