Menu
▾
▴
1 Attachments
#1713 Whole note/dotted note collision in polyphony
Originally created by: *anonymous
Originally created by: ColinPKC...@gmail.com
Originally owned by: k-ohara5...@oco.net
Reported by Connor Harris:
\version "2.14.1"
%{ When whole notes and shorter notes are in polyphony, they normally appear as
in the measure on the left. With dotted notes, though, LilyPond moves the
shorter note to the right of the whole note, but not far enough, causing a
collision. %}
<< {d'2 s2 d'2.} \\ {d'1 d'1}>>
Note: this may be related to issue 1546, Breve collides with noteheads in other voices?
Originally posted by: ColinPKC...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-countdown
Originally posted by: janek.li...@gmail.com
@Pavel (comment 22):
"The patch removes several constants [...] but I don't think it's a good approach for Lilypond."
Generally i agree, but not in this specific case. The original code is very hard-wired and quite broken. It produces more bad (completely bad, not just imperfect) results than good ones.
"A generic algorithm makes it harder to tweak one distance without tweaking other distances."
but a generic algorithm makes it easier to change many things in a coordinated, coherent way.
"I believe there should be no slight changes."
If the original code produced at least acceptable results, i would agree. But it didn't. Even if Keith's patch makes 5% of cases slightly worse, it makes half of cases significantly better. In my opinion we should accept it, and then improve it.
compare
http://lilypond-stuff.1065243.n5.nabble.com/file/n5705591/close-collisions_current.pdf
with
http://lilypond-stuff.1065243.n5.nabble.com/file/n5705591/close-collisions_new.pdf
"We need a big test, a matrix with all combinations of notes that can collide."
I thing the above one is good. The source is in a comment in Rietveld http://codereview.appspot.com/6189048/diff/9003/input/regression/collision-whole.ly#newcode16
"That should cover all styles, all standard shapes of noteheads, all durations and all pitch differences."
Are you sure? A matrix like the above one (or bigger) for 15 styles of noteheas and about 15 special shapes used in various shapeNotes? That's about 1000 cases (or more).
I'm not opposed to having an algorithm that would handle all collisions of notes with any shape. But that surely cannot be done with "just-right human tweaked numbers"; we would have to teach Lily recognizing the actual shape of the noteheads.
I think it is possible to do this: Mike's work on skylines is very promising in this regard. If you haven't followed the discussion about it, see issue 2148, http://codereview.appspot.com/5626052/ and compare outlines in these files:
http://lilypond-stuff.1065243.n5.nabble.com/file/n5705592/Eja-Mater_master.pdf
http://lilypond-stuff.1065243.n5.nabble.com/file/n5705592/Eja-Mater_skylines.pdf
Related
Issues:
#2148Originally posted by: ColinPKC...@gmail.com
Counted down to 20120515, please push
Labels: -Patch-countdown Patch-push
Originally posted by: k-ohara5...@oco.net
[r31ae5880931a923a88c3a12a66d113436dfb97af]
Labels: fixed_2_15_39
Originally posted by: k-ohara5...@oco.net
(No comment was entered for this change.)
Status: Fixed
Originally posted by: Elu...@gmail.com
(No comment was entered for this change.)
Status: Verified
.