Patch: new --> needs_work
In case you can read this, I still haven't figured out the right way to disable write access...
Oh no, this should not have worked! Please use GitLab
Prevent race condition in `-dfont-ps-resdir`
Passes make, make check and a full make doc.
Split glyph contours in up/down segments for skylines
Patch does not apply to current master
dynamics on skips confuse cross-staff stems
Passes make, make check and a full make doc. (reg test diffs as commend above)
output-distance: set device properties in batch driver file
commit d99780e93bfeafbcafce1c2653eac8e294057e84 Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Sat May 9 11:49:03 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Sun May 10 10:43:12 2020 +0200 output-distance: set device properties in batch driver file This fixes the output quality of the regtest results. Previously, the code sets a device by doing (png16m) finddevice this put a default device on the stack, ignoring the command-line arguments. To fix this, specify...
Remove define causing a warning
commit 3ba316af1f73395294df29ee34f3472df31b7e00 Author: Jonas Hahnfeld <hahnjo@hahnjo.de> AuthorDate: Mon May 4 16:19:00 2020 +0200 Commit: Jonas Hahnfeld <hahnjo@hahnjo.de> CommitDate: Sat May 9 20:04:45 2020 +0200 Issue 5963: Remove define causing a warning These lines were added in commit 25beb8d01b in 2008 to provide compatibility with GCC 3.4 which clearly does not support C++11. (The warning is visible since commit b96b6334c0 which put system headers last, so that the define is already provided...
Add option to use Ghostscript API instead of forking
commit ddfd0b4fb548aa32bfd809014502de0666d514f3 Author: Jonas Hahnfeld <hahnjo@hahnjo.de> AuthorDate: Mon Apr 27 20:54:43 2020 +0200 Commit: Jonas Hahnfeld <hahnjo@hahnjo.de> CommitDate: Sat May 9 20:04:45 2020 +0200 Issue 5949: Add option to use Ghostscript API instead of forking This is much more efficient than the current scheme when converting many PostScript files, for example when building the documentation. For the Notation Reference, lilypond-book now takes ~2m30s instead of 5m to compile...
const& https://codereview.appspot.com/566080043
jonas https://codereview.appspot.com/566080043
rebase on bugfix change https://codereview.appspot.com/569700043
I don't think this is true. Reference?
Use FT_Outline_Decompose https://codereview.appspot.com/566080043
Fix style issues https://codereview.appspot.com/554030043
reserve mem; clear mem; c++11 loops https://codereview.appspot.com/569740046
Cosmetic fixes to accidental.cc
commit 4088a7813706aafd48dd551aa19d019970088412 Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Sun May 3 20:55:05 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Sat May 9 11:28:51 2020 +0200 Cosmetic fixes to accidental.cc
SVG backend: Use bounding box as skylines for markup / Compute SVG skyline based on original data
commit 4860434b122611df632dfd9aaa21c430e4b67819 Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Sat May 2 11:46:02 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Sat May 9 11:28:51 2020 +0200 Compute SVG skyline based on original data Since stencil data is used as input to formatting decisions, this will make SVG output more similar to PS/PDF output.
https://sourceforge.net/p/testlilyissues/issues/5940/ never was "push", it's currently in "review".
rebase? https://codereview.appspot.com/572130043
Remove deprecated context properties
Patch Set 2 : Improve messages https://codereview.appspot.com/561810045/
Prevent race condition in `-dfont-ps-resdir`
Passes make, make check and a full make doc.
Looks like what Han-wen did was push that patch anyway.
Passes make, make check and a full make doc. Patch set 1 diffs (~6mb) https://cloud-u8zj2dc4b.yourownnet.eu/s/AkGBgPZEpb5nrLH
I'd have to agree, else it may seem we're backdooring the process.
Multi_measure_rest_engraver segfaults when its context doesn’t include Staff_symbol_engraver.
Passes make, make check and a full make doc. Reg test diff attached
output-distance: set device properties in batch driver file
Passes make, make check and a full make doc.
Stop smobifying Transform
Passes make, make check and a full make doc.
That sounds like it would be more sensible to remove that issue from "push" until the consequences have been figured out rather than to fasttrack everything.
Make Scheme_hash_table just use the native hash table type. This
Passes make, make check and a full make doc.
[proposal] Make Staff_symbol::line_count public and use it when <line_positions>’s not needed</line_positions> https://codereview.appspot.com/576090043
this is split off from https://codereview.appspot.com/569700043/ . Since that one is in "push" status already, I suggest to fasttrack this, if Werner is agrees with this change.
Add OTC font support for `-dfont-ps-resdir`
I've pushed to staging. commit 116b2765ea458daa4ab32a7ecaff79eb0ab5306f Issue 5960/3: Doc: Remove unnecessary description about -dfont-ps-resdir commit a2ff250f1fb4adb23c82000affe475ef34820cc6 Issue 5960/2: Add OTC font support for -dfont-ps-resdir commit 92db18d3141484d3c46722f6ed911c253e06d0f4 Issue 5960/1: Add ly:extract-subfont-from-collection
looks like the bugfixes caused minor formatting diffs. I'll separate out the bugfixes so we can be sure.
programming error/segfault while omitting Fingering.stencil with fingeringOrientations set 'left
Patch on countdown for May 11th
dynamics on skips confuse cross-staff stems
Patch on countdown for May 11th
Multi_measure_rest_engraver segfaults when its context doesn’t include Staff_symbol_engraver.
Patch on countdown for May 11th - although there are what look like relatively simple comments on Rietveld that need addressing
SVG backend: Use bounding box as skylines for markup / Compute SVG skyline based on original data
Patch counted down please push - don't forget this goes on top of another patch. (needs https://codereview.appspot.com/555760043/)
Add option to use Ghostscript API instead of forking
Patch counted down - please push
Add OTC font support for `-dfont-ps-resdir`
Patch counted down - please push
Cosmetic fixes to accidental.cc
Patch counted down - please push
Remove define causing a warning
Patch counted down - please push
Split glyph contours in up/down segments for skylines
Passes make, make check and a full make doc. Reg test diffs here (patch 7) ~ 6MB! https://cloud-u8zj2dc4b.yourownnet.eu/s/qJNCHJzFsmrRM3R
jonas. https://codereview.appspot.com/569700043
Use axis indexing to clarify different behaviors for X/Y skylines
output-distance: create PNG files in batch
commit 1c1d51861861e11f7f6ffe664fb471bececc7baf Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Sat May 2 14:25:13 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Fri May 8 09:13:27 2020 +0200 output-distance: create PNG files in batch
Use axis indexing to clarify different behaviors for X/Y skylines
commit 766070bdbcc1da6ac123f7003db5bf3ba073defd Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Fri May 1 19:59:30 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Fri May 8 09:14:04 2020 +0200 Use axis indexing to clarify different behaviors for X/Y skylines
Calculate skylines only once.
commit 750d6a547567409b6aa2d49bcb34912774aae4bc Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Sun Apr 26 15:39:01 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Fri May 8 09:14:16 2020 +0200 Calculate skylines only once. Before, Axis_group_interface::skyline_spacing() would call the function add_interior_skylines(), which recursed into VerticalAxisGroups. This caused staff-skylines to be computed twice: once as part of the Staff's VerticalAxisGroup, and once to...
Create skylines directly from glyph outlines.
commit 79ec62e686a95bbb8bb8b61a3dcbd702de0abb91 Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Sat May 2 09:33:36 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Fri May 8 09:14:30 2020 +0200 Create skylines directly from glyph outlines. This avoids creating garbage for the intermediate Scheme data to transport the glyph outlines. a20f8b786e - Create skylines directly from glyph outlines. baseline: 267e894e79 Thread skyline construction through stencil interpretation...
Avoid using Skyline_pair::insert.
commit b872b327c471a9538d93fba21ff0385709aae2c2 Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Sun May 3 20:31:10 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Fri May 8 09:14:55 2020 +0200 Avoid using Skyline_pair::insert. Skyline::insert(Box) creates a skyline and merges it. In this case, the boxes are non-overlapping, so it is trivial to create a skyline out of them. Remove Skyline::insert(). Using it repeatedly leads to a quadratic complexity, so it's best...
Convert stencil to skyline directly
commit 96b0e346adebe12ac742044c02cc8c2152e89977 Author: Han-Wen Nienhuys <hanwen@lilypond.org> AuthorDate: Sat May 2 09:31:13 2020 +0200 Commit: Han-Wen Nienhuys <hanwen@lilypond.org> CommitDate: Fri May 8 09:13:08 2020 +0200 Convert stencil to skyline directly Gets rid of more intermediate storage. eb3e0449f4 - Convert stencil to skyline directly baseline: 78d4ae8627 Thread skyline construction through stencil interpretation args: -I carver MSDM memory: med diff -1464 (stddevs 202 98, n=3) memory:...
Split glyph contours in up/down segments for skylines
Fails make check ... Making Documentation/topdocs/out/AUTHORS.txt < texi Making Documentation/topdocs/out/NEWS.txt < texi [1]+ Done gitk (wd: ~/lilypond-git) (wd now: ~/lilypond-git/build) . ---------------------------------------------------------------------- Ran 1 test in 0.002s OK testing /home/james/lilypond-git/scripts/build/output-distance.py Please check the logfile /home/james/lilypond-git/build/scripts/build/./out/output-distance-test.log for errors last 20 lines: GNU LilyPond 2.21.2 test...
dynamics on skips confuse cross-staff stems
Passes make, make check and a full make doc. (reg test diffs as commend above)
programming error/segfault while omitting Fingering.stencil with fingeringOrientations set 'left
Passes make, make check and a full make doc. Reg test diffs attached
rebase; drop experimental work https://codereview.appspot.com/569700043
rebase https://codereview.appspot.com/569700043
Fix texidoc style issues in cross-staff-stem-offset.ly https://codereview.appspot.com/554030043
Fix regtests (conditional should only apply to horizontal fingerings) https://codereview.appspot.com/567560043
programming error/segfault while omitting Fingering.stencil with fingeringOrientations set 'left
Yowza. Not good indeed. Thanks for catching this James, I should’ve paid more attention!
Remove ly:lexer-keywords command
Issue 5957: Remove ly:lexer-keywords command author David Kastrup <dak@gnu.org> Sat, 2 May 2020 10:43:55 +0100 (11:43 +0200) committer David Kastrup <dak@gnu.org> Thu, 7 May 2020 10:29:00 +0100 (11:29 +0200) commit 53d3c069de1f3c20aa42179f347836a35ce46231
Further cleanup/regularisation of Callback_wrapper classes and trampolines
Issue 5953/1: Make Callback_wrapper a class template author David Kastrup <dak@gnu.org> Wed, 29 Apr 2020 23:12:10 +0100 (00:12 +0200) committer David Kastrup <dak@gnu.org> Thu, 7 May 2020 10:28:49 +0100 (11:28 +0200) commit 6a95c1d34f7cb7e4fb67d2279a917c9ef3cfdd6b Issue 5953/2: Callback_wrapper:: move trampolines and make_smob to Callbacks class author David Kastrup <dak@gnu.org> Fri, 1 May 2020 20:12:10 +0100 (21:12 +0200) committer David Kastrup <dak@gnu.org> Thu, 7 May 2020 10:28:49 +0100 (11:28...
Doc: Usage - update text about Open/LibreOffice
Issue 5954: update OOoLilyPond info in usage manual staging author Kevin Barry <barrykp@gmail.com> Sat, 2 May 2020 10:17:30 +0100 (10:17 +0100) committer James Lowe <pkx166h@runbox.com> Thu, 7 May 2020 18:43:19 +0100 (18:43 +0100) commit 57617f931023d96645723d8139579e09948942f1 Thanks Kevin
programming error/segfault while omitting Fingering.stencil with fingeringOrientations set 'left