Re: [Teem-users] Teem version 1.11 branch

[Gordon L. K. <gl...@uc...>]

Hello,

On Nov 25, 2009, at 3:49 PM, Steve Pieper wrote:

> Hi Guys -
>
> I guess in all the biff discussion I missed the part where biffAdd  
> was to be removed rather than augmented with the f variants.

biffAdd has not been removed.

> See the code below and the error it generates.  I only have this a  
> few places and don't mind changing to the new call, but other people  
> might have a lot more code that needs changing.

It looks like that code is some copy-paste of code from an older  
version of Teem, especially since its using the "TEN" biff key, which  
is what the "ten" library uses for errors it generates.  I don't think  
this is a typical example of how applications use Teem, is it?

More to the point: its using the BIFF_STRLEN #define to define the  
length of a local buffer for sprintf'ing an error message into.   
BIFF_STRLEN was never meant for use in code outside Teem, and now that  
biffAddf was added, there was no longer any need for it.  So I removed  
it, thinking that no other code outside Teem would be using it.

You can replace the code with:

if (!(nout && nin)) {
    biffAddf(TEN, "%s: got NULL pointer", me);
    return 1;
  }

But to me the bigger issue is- why is this code apparently re- 
implementing a function that's already in Teem?

Gordon

>
> -Steve
>
> p.s. all this API grousing doesn't take away from my admiration for  
> Teem :)
>
>
>
>  char me[]="tenSpaceDirectionReduce", err[BIFF_STRLEN];
>
>  if (!(nout && nin)) {
>    sprintf(err, "%s: got NULL pointer", me);
>    biffAdd(TEN, err); return 1;
>  }
>
>
> [  0%] Building CXX object Libs/vtkTeem/CMakeFiles/vtkTeem.dir/ 
> vtkNRRDReader.o
> /Users/pieper/slicer3/latest/Slicer3/Libs/vtkTeem/vtkNRRDReader.cxx:  
> In member function 'int  
> vtkNRRDReader::tenSpaceDirectionReduce(Nrrd*, const Nrrd*, double*)':
> /Users/pieper/slicer3/latest/Slicer3/Libs/vtkTeem/vtkNRRDReader.cxx: 
> 795: error: 'BIFF_STRLEN' was not declared in this scope
> /Users/pieper/slicer3/latest/Slicer3/Libs/vtkTeem/vtkNRRDReader.cxx: 
> 802: error: 'err' was not declared in this scope
> /Users/pieper/slicer3/latest/Slicer3/Libs/vtkTeem/vtkNRRDReader.cxx: 
> 806: error: 'err' was not declared in this scope
> /Users/pieper/slicer3/latest/Slicer3/Libs/vtkTeem/vtkNRRDReader.cxx: 
> 810: error: 'err' was not declared in this scope
> /Users/pieper/slicer3/latest/Slicer3/Libs/vtkTeem/vtkNRRDReader.cxx: 
> 815: error: 'err' was not declared in this scope
> /Users/pieper/slicer3/latest/Slicer3/Libs/vtkTeem/vtkNRRDReader.cxx: 
> 824: error: 'err' was not declared in this scope
> make[2]: *** [Libs/vtkTeem/CMakeFiles/vtkTeem.dir/vtkNRRDReader.o]  
> Error 1
> make[1]: *** [Libs/vtkTeem/CMakeFiles/vtkTeem.dir/all] Error 2
> make: *** [all] Error 2
>
>
> Daniel Blezek wrote:
>> Congratulations!  We'll switch to the new branch and see how things  
>> go
>> (Monday, when we can watch the dashboard).
>> Cheers,
>> -dan
>> On 11/25/09 2:15 PM, "Gordon L. Kindlmann" <gl...@uc...> wrote:
>>> Hello,
>>>
>>> I've created an svn branch for Teem version 1.11:
>>>
>>> svn co https://teem.svn.sourceforge.net/svnroot/teem/teem/branches/Teem-1.11/
>>>
>>> If you have applications that have been using an earlier version of
>>> Teem, let us know if you have problems using this version.
>>>
>>> Until the 1.11 release, I will periodically copy commits to the  
>>> trunk
>>> over to this branch.
>>>
>>> There will be no changes to existing APIs in that branch.  There may
>>> be some new functions added.
>>>
>>> Gordon
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Let Crystal Reports handle the reporting - Free Crystal Reports  
>>> 2008 30-Day
>>> trial. Simplify your report design, integration and deployment -  
>>> and focus on
>>> what you do best, core application coding. Discover what's new with
>>> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
>>> _______________________________________________
>>> teem-users mailing list
>>> tee...@li...
>>> https://lists.sourceforge.net/lists/listinfo/teem-users
>