Re: [Teem-users] int vs unsigned int

[Gordon K. <gk...@bw...>]

ah, that's an interesting idea, and in a purist sense its probably 
right things to do.

There are actually two cases: (1) the index to identify a nrrd's axis: 
there is no way that a nrrd is going to have millions of dimensions, 
because of more entrenched implementation decisions based on a compile 
time limit on the number of dimensions (via NRRD_DIM_MAX).  So here I 
think unsigned int is legit.

(2) the index to identify position along an axis.  Actually, this 
should probably be size_t, since that's the most straightforward type 
that will be 64-bit array index friendly.  The question then is whether 
a nrrd could have more than 4294967296 samples along a single axis.  It 
would be stupid to assert that this could never happen.  On the other 
hand, using size_t can be annoying, such as when you want to print it 
via printf(): there is no standard conversion sequence for values of 
type size_t.

What do others think of case #2 here?

Gordon

On Jul 6, 2005, at 12:07 PM, Michael Callahan wrote:

> Maybe you should make an 'index_type' so that you can more easily 
> update
> them to be 64 bit values at some point within the next 5 years when 
> that
> becomes useful?
>
>   Michael
>
> On Wed, 2005-07-06 at 03:23 -0400, Gordon Kindlmann wrote:
>> hi-
>>
>> Along the same lines, functions like nrrdSlice() should take the axis
>> index as type "unsigned int", and not "int".
>>
>> Right?
>>
>> Gordon
>>
>> On Jul 6, 2005, at 1:46 AM, Gordon Kindlmann wrote:
>>
>>> hello,
>>>
>>> In the Nrrd struct, the "dim" (dimension) field has type "int", as
>>> does the "size" field in the NrrdAxisInfo.
>>>
>>> In both cases, it would be more logical to be using type "unsigned
>>> int", since in both cases, negative values are impossible, and a 
>>> value
>>> of 0 is already used to indicate an invalid state.
>>>
>>> What do you think of me changing these?
>>>
>>> Gordon
>>>
>>>
>>>
>>> -------------------------------------------------------
>>> SF.Net email is sponsored by: Discover Easy Linux Migration 
>>> Strategies
>>> from IBM. Find simple to follow Roadmaps, straightforward articles,
>>> informative Webcasts and more! Get everything you need to get up to
>>> speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
>>> _______________________________________________
>>> teem-users mailing list
>>> tee...@li...
>>> https://lists.sourceforge.net/lists/listinfo/teem-users
>>
>>
>>
>> -------------------------------------------------------
>> SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
>> from IBM. Find simple to follow Roadmaps, straightforward articles,
>> informative Webcasts and more! Get everything you need to get up to
>> speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
>> _______________________________________________
>> teem-users mailing list
>> tee...@li...
>> https://lists.sourceforge.net/lists/listinfo/teem-users
>