Menu

#371 TRDPSpy: Wrong ComId display for ComIds > 2147483647

2.1.0.0
closed
F Weisp
2022-03-07
2021-07-19
No

Problem detected and analyzed by Chirag Khangani:
The problem is with the TRDPSpy plugin part of the IPTSpy. In the main capture pane, the comIds of the captured packets are inferred as INT32 and hence any comId values greater than 2147483647 (max value of INT32) result into being displayed as negative comIds. The comId should be interpreted as UINT32.

The below pane which shows each packet in detail infers the comIds correctly as UINT32. Also, the filtering based on TRDP comId works correctly. The problem is only, as described above, in the main capture pane where it displays all the captured TRDP packets and their comIds (as INT32 instead of UINT32) . Check the attached screenshot 'TRDP_comId_signed' for reference.

The problem is in https://sourceforge.net/p/tcnopen/trdp/HEAD/tree/trunk/trdp/spy/src/trdp_spy/packet-trdp_spy.c line 739 wherein the format specifier used to print the comId in printf is %d instead of %u.

1 Attachments

Discussion

  • Armin-Hagen Weiss

    • labels: --> SPY
     
  • Armin-Hagen Weiss

    Hi Thorsten, do You have time to Do it?

     
  • Armin-Hagen Weiss

    • status: open --> accepted
    • assigned_to: F Weisp
     
  • Armin-Hagen Weiss

    • labels: SPY --> SPY, 2306, 2307
    • status: accepted --> closed
     
  • Thorsten

    Thorsten - 2022-03-06

    Didn't notice this. I am not actively listening.
    I am currently switching to wireshark 3.6 and will pull your/Florian's fix.

     
  • Thorsten

    Thorsten - 2022-03-07

    Done: Plugin for 3.6 available providing support for multiple XML files and trying to be helpful finding inconsistencies.
    https://github.com/T12z/TCNopen/tree/master/trdp/spy/plugins/3.6/epan

     

Log in to post a comment.

MongoDB Logo MongoDB