#20 http vfs doesn't clean up tokens

v1.0 (example)
closed-fixed
nobody
5
2006-11-24
2004-03-03
Neil Madden
No

The http vfs implementation leaks http sessions.

Firstly, in vfs::http::Mount, there is a line:

set token [http::geturl $dirurl -validate 1]

There doesn't seem to be a reason for this to be there, as it's
result is never checked, and $token is not referenced ever again.

Leak number 2 is in vfs::http::open, where the url is retrieved with
http::geturl and then copied into a memchan. This is missing a
http::cleanup after the copy has been done.

Discussion

  • Vince Darley

    Vince Darley - 2004-03-09

    Logged In: YES
    user_id=32170

    Could you attach a patch to fix these problems, since you've
    diagnosed them so well?

     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2006-11-24

    Logged In: YES
    user_id=72656
    Originator: NO

    I've rewritten vfs::http for 1.3.1.

     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2006-11-24
    • status: open --> closed-fixed
     

Log in to post a comment.