#472 Removing commas is slimming!

closed-accepted
None
3
2007-04-20
2006-06-30
afredd
No

There are a large number of cases where string literals
passsed to vararg functions are split over multiple
lines but with a comma separating them. The most common
are in calls to Tcl_AppendResult.

By removing the comma separating the string literals,
you save all round:

* smaller object code (one less function argument
to push)
* one less '\0' in the strings table
* faster run time (one less time round the varargs
handling code)
* smaller source code!

Attached is a file containing all the occurences i
could grep out of the Tcl source (there are more in
Tk too) plus a patch for the first file in the list.
I'll submit patches for the rest if someone's
willing to apply them... although the changes are
absurdly trivial :-)

Discussion

  • afredd

    afredd - 2006-06-30

    List of function calls with unnecesary commas...

     
  • Donal K. Fellows

    • assigned_to: nobody --> dgp
     
  • Don Porter

    Don Porter - 2006-08-09
    • priority: 5 --> 3
    • assigned_to: dgp --> kennykb
     
  • Kevin B KENNY

    Kevin B KENNY - 2007-04-20

    Logged In: YES
    user_id=99768
    Originator: NO

    Sure, couldn't hurt. Unlikely to help much, but might as well put it in.

     
  • Kevin B KENNY

    Kevin B KENNY - 2007-04-20
    • status: open --> closed-accepted