Menu

#409 disable interp->result access support

closed-accepted
9
2008-11-26
2005-04-02
Don Porter
No

Attached patch disables all code
that supports the legacy
interp->result field.

To restore it, compile with
USE_DIRECT_INTERP_RESULT_ACCESS
defined.

Discussion

  • Don Porter

    Don Porter - 2005-04-04

    Logged In: YES
    user_id=80530

    Patch updated to include headers
    and tests. (Thanks jenglish!)

     
  • Don Porter

    Don Porter - 2005-04-04
     
  • Don Porter

    Don Porter - 2005-04-04

    Logged In: YES
    user_id=80530

    Second patch goes beyond
    disabling to completely
    removing support for
    interp->result access.

     
  • Don Porter

    Don Porter - 2005-04-04
     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2005-04-04

    Logged In: YES
    user_id=72656

    Without looking at the patch, I assume that this was done
    without changing the size of the Tcl_Interp structure, which
    would cause ABI issues.

     
  • Don Porter

    Don Porter - 2005-04-04

    Logged In: YES
    user_id=80530

    correct. no fields are removed by the patch.
    (though public access to them is).

     
  • Don Porter

    Don Porter - 2005-04-05
    • assigned_to: dkf --> dgp
     
  • Donal K. Fellows

    Logged In: YES
    user_id=79902

    I worry about old (broken) code that accesses that field
    directly.
    OK, it's broken, but I don't want to be the one explaining
    that to users who find that their code no longer compiles
    because of poorly written code that happens to not be
    called. (That's quite possible with error handling code).

    OTOH, I was planning to do this (or rather a total purge)
    very early in the 9.0 cycle.

     
  • Don Porter

    Don Porter - 2005-04-06

    Logged In: YES
    user_id=80530

    changed your tune a little bit since
    you wrote the comment at lines 632-639
    of tclResult.c, then? :D

     
  • Donal K. Fellows

    • labels: --> 45. Parsing and Eval
     
  • Donal K. Fellows

    Logged In: YES
    user_id=79902

    "Consistency is the sign of a small mind"
    :-p

     
  • Don Porter

    Don Porter - 2008-09-29
    • priority: 5 --> 9
    • assigned_to: dgp --> kennykb
     
  • Kevin B KENNY

    Kevin B KENNY - 2008-11-26
    • status: open --> closed-accepted
     
MongoDB Logo MongoDB