From: <no...@so...> - 2001-03-15 23:42:12
|
Patches item #408840, was updated on 2001-03-15 09:46 You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=310894&aid=408840&group_id=10894 >Category: None Group: None Status: Open Priority: 5 Submitted By: Vince Darley (vincentdarley) Assigned to: Nobody/Anonymous (nobody) Summary: Patch for TIP 17 Initial Comment: Patch doesn't yet contain documentation for the new C API. Tcl level docs are all there. ---------------------------------------------------------------------- >Comment By: Don Porter (dgp) Date: 2001-03-15 15:44 Message: Logged In: YES user_id=80530 Maintainers from the following areas must approve this patch before it can be integrated: Commands A-H DKF Commands I-L DKF Commands M-Z DKF Memory Allocation Compiler and Objects MS Event Loops JN File System DS, JI (*) Pathname Management DS, JI (*) Channel System AK Channel Commands AK Dynamic Loading KK, DS, JI, JN Init - Library - Autoload DGP, DS, JI resource Command DS, JI registry Package KK dde Package KK Configure and Build Tools MD (*) Dan Steffen and Jim Ingham are Mac-specific maintainers of the Pathname Management and File System areas. There's no general maintainer for those sections. Would you be interested in that job, Vince? After this patch, you'll probably know that part of the code better than anyone. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2001-03-15 14:49 Message: Logged In: YES user_id=80530 Problems with this patch: 1) No C API documentation. 2) Tclfs_* routines should be Tcl_FS* 3) Changed error messages cause these tests to fail: cmdAH-5.2 cmdAH-30.1 cmdAH-30.2 cmdAH-30.3 cmdAH-30.4 cmdAH-30.5 cmdAH-30.6 cmdAH-30.7 fCmd-6.24 fCmd-6.25 unixFCmd-1.1 These tests should be updated to expect the new error messages. 4) One other test suite failure in test unixFCmd.test: could not read "/dev/../devices/pseudo/mm@0null,": no such file or directory It appears that [file type] requires a "normalized" path name to function properly. It probably should not have that requirement. If it must, then the test needs updating. Also the comma appended to the end of the file name in the error message doesn't look good. It's not in the file name itself. Could be a problem with [file join]. That's all I see so far on Solaris. Things look considerably worse on my Alpha. More on that later... ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2001-03-15 13:48 Message: Logged In: YES user_id=80530 ...and second, the changes to the other files. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2001-03-15 13:47 Message: Logged In: YES user_id=80530 OK. SF replied that patch sizes must be > 20 bytes and < 256000 bytes. This patch is too big. So.... trying to upload it in two parts. First, the changes to files in generic/ (except tclTest.c)... ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2001-03-15 12:52 Message: Logged In: YES user_id=80530 Attempt to upload the patch file... ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2001-03-15 12:39 Message: Logged In: YES user_id=80530 In case you didn't know, there's no patch file attached. More trouble with SF's file uploading?! ---------------------------------------------------------------------- You can respond by visiting: http://sourceforge.net/tracker/?func=detail&atid=310894&aid=408840&group_id=10894 |