[Tcl-bugs] [ tcl-Bugs-3609575 ] sha256 output is wrong on 32bit Linux

[SourceForge.net <no...@so...>]

Bugs item #3609575, was opened at 2013-03-30 16:20
Message generated for change (Comment added) made by ferrieux
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=3609575&group_id=10894

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: 55. Other Tools
Group: current: 8.6.0
Status: Pending
Resolution: Invalid
Priority: 5
Private: No
Submitted By: https://www.google.com/accounts ()
Assigned to: Andreas Kupries (andreas_kupries)
Summary: sha256 output is wrong on 32bit Linux 

Initial Comment:
I am using ActiveState Tcl for 32bit and 64bit Linux. 
The command is:
sha2::sha256 -hex tk

The output is:
32bit Linux:
0b9422c2ca451b24fea81114412fb2c61e2ced68889466119b72d36c4ec3c337

64bit Linux:
1ec22d56dbbc91e849b00643bc4f10eb764441c93bde5c6090fe81db55cf6932

When using any web based sha256 generators the output is:
1ec22d56dbbc91e849b00643bc4f10eb764441c93bde5c6090fe81db55cf6932

Therefore, 32bit sha256 output seems to be incorrect. 

----------------------------------------------------------------------

>Comment By: Alexandre Ferrieux (ferrieux)
Date: 2013-03-31 13:58

Message:
A cursory look at the code reveals the use of constants like this:

    expr {int(0xc1059ed8)}

But since int() is the tricky, platform-dependent "truncate to machine
word" operator, its result (and sign extension thereof, in this specific
case) will suffer when moving from 32 to 64 bits architectures.
I'd risk that using wide() instead of int() throughout the package should
make it robustly behave like the 64-bit version (which is supposed to be
the good one according to this report).



----------------------------------------------------------------------

Comment By: Donal K. Fellows (dkf)
Date: 2013-03-31 09:32

Message:
That's probably a bug in the sha256 code, which is part of tcllib (and not
part of tcl properly). Assigning to the master of tcllib for
confirmation...

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=3609575&group_id=10894