Re: [TCLCORE] Removing "thin wrappers" in Tk

[Brian G. <bri...@ea...>]

On Feb 27, 2013, at 5:21 AM, Jan Nijtmans <jan...@gm...> wrote:

> 2013/2/27 Porter, Don <don...@ni...>:
>> 
>> Current trunk commit message for Tk:
>> 
>> "Eliminate all Tcl_GetIndexFromObj calls,
>> which is only a thin wrapper around
>> Tcl_GetIndexFromObjStruct."
>> 
>> Thin wrappers are good!  They make code easier
>> to read and understand.  There's no need to
>> insist on using the most complex interface available
>> for a task when a simpler one will do.
>> 
>> What's the purpose of changes like this?
> 
> The thing I really want to do is implement thin wrappers
> with macros, not with functions (see my changes in "novem")
> Unfortunately that means that Tk 8.6 cannot be compiled
> against novem any more without magic like:
>   <http://core.tcl.tk/tk/artifact/8df77f3567b12472e4e0e7d73a39b27761d62960?ln=1251-1273>
> that's the magic I am trying to get rid of.

I like the shortcut, please don't eliminate it.
I think I'd rather see inlining instead of macros.
http://gcc.gnu.org/onlinedocs/gcc/Inline.html

-Brian