From: Jan N. <jan...@gm...> - 2012-07-17 17:34:49
|
2012/7/17 Trevor Davel (Twylite) <tw...@cr...> > Hi, > > A recent change was committed to thread-2-7-branch: "Allow package to be > compiled with MSVC again by defining MODULE_SCOPE in the MSVC makefile". > http://core.tcl.tk/thread/info/8f62b3ac7f > > Please can we not do this. > ... > This ensures that public headers using MODULE_SCOPE don't propagate the > problem of defining MODULE_SCOPE to other projects. It also solves the > problem for mixed C/C++ environments, and stops Thread's makefile.vc > from moving even further from the TEA default. > There's nothing wrong with defining MODULE_SCOPE in the makefile. But only including tclThread.h should not need the MODULE_SCOPE macro. The real problem here is that MODULE_SCOPE functions don't belong in an external header file. Proposed solution: move internal function definitions like Sv_Init to a new internal header file tclThreadInt.h. That part I agree with. I consider Joe's commit as a quick-fix, but more cleanup should be done. Regards, Jan Nijtmans |