[Tcl-bugs] [ tcl-Bugs-3544932 ] Visual studio compiler check fails

[SourceForge.net <no...@so...>]

Bugs item #3544932, was opened at 2012-07-17 00:23
Message generated for change (Comment added) made by nijtmans
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=3544932&group_id=10894

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: 53. Configuration and Build Tools
Group: development: 8.6b3
>Status: Pending
>Resolution: Fixed
Priority: 9
Private: No
Submitted By: Decoster Jos (decosterjos)
Assigned to: Pat Thoyts (patthoyts)
Summary: Visual studio compiler check fails

Initial Comment:
When using the makefile.vc in the win directory to build Tcl or the thread and itcl packages, there is a check to see if the build is configured to build with Microsoft Visual Studio/C. This check is not complete (e.g fails when using Visual Studio Express 10 and SDK 7.1 to build 64 bit). The attached patches remove the check. When you're using the makeifle.vc to build Tcl/Itcl/Thread, you'll need nmake, which is only available when the VC build environment is configured.

Jos. 

----------------------------------------------------------------------

>Comment By: Jan Nijtmans (nijtmans)
Date: 2012-07-17 07:25

Message:
Fixed in Tcl and Tk (all open branches), thread, tdbc and itcl.

Jos, please veryfy whatever you can (I don't have
a 64-bit build environment)

----------------------------------------------------------------------

Comment By: Decoster Jos (decosterjos)
Date: 2012-07-17 05:51

Message:
This should be added to the test in the different makefile.vc files:

 && !defined(WINDOWSSDKDIR)

(note the upper case). Want me to make a patch for this change or if the
line above sufficient?

----------------------------------------------------------------------

Comment By: Decoster Jos (decosterjos)
Date: 2012-07-17 05:39

Message:
I'll prepare a patch after testing.

----------------------------------------------------------------------

Comment By: Decoster Jos (decosterjos)
Date: 2012-07-17 05:37

Message:
That should do it. Same change needed in itcl and thread.

----------------------------------------------------------------------

Comment By: Jan Nijtmans (nijtmans)
Date: 2012-07-17 05:34

Message:
So, how about adding
     && !defined(WindowsSDKDir)
to the end of the existing check.
Does that work, or are additional
changes needed?

----------------------------------------------------------------------

Comment By: Decoster Jos (decosterjos)
Date: 2012-07-17 05:29

Message:
Hi Jan,

While I agree on that, I could not see what would be a good candidate to
add in the VC-express + SDK setup. These are available:

INCLUDE (has a list of VC include paths)
LIBS or LIBPATH (list of VC lib paths)
WindowsSDKDir



----------------------------------------------------------------------

Comment By: Jan Nijtmans (nijtmans)
Date: 2012-07-17 05:22

Message:
I have doubts about this one: If the 64-bit compiler has
different macro's, shouldn't that be tested for, in
stead of simply removing the check?

Pat, you seem to be the expert in this.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=3544932&group_id=10894