[Tcl-bugs] [ tcl-Bugs-3543020 ] Thread extension not building with makefile. when in release

[SourceForge.net <no...@so...>]

Bugs item #3543020, was opened at 2012-07-12 07:02
Message generated for change (Comment added) made by nijtmans
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=3543020&group_id=10894

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: 80. Thread Package
Group: development: 8.6b3
>Status: Pending
>Resolution: Fixed
Priority: 9
Private: No
Submitted By: Decoster Jos (decosterjos)
>Assigned to: Jan Nijtmans (nijtmans)
Summary: Thread extension not building with makefile. when in release

Initial Comment:
The Threads package has a makefile.vc to build with Visual Studio in directory win/vc. When adding the Thread package to the pkgs directory for a 'batteries included' Tcl release, the makefile.vc file is moved from directory win/vc to directory win. This invalidates the ROOT variable used in the makefile.vc. It still has value ..\.. where after copying it should become ..

----------------------------------------------------------------------

>Comment By: Jan Nijtmans (nijtmans)
Date: 2012-07-16 12:18

Message:
Done as suggested by Jos. OK?

Thanks, Jos!

----------------------------------------------------------------------

Comment By: Decoster Jos (decosterjos)
Date: 2012-07-16 07:54

Message:
The attached file 'vc.diff' is the 'fossil diff' output after moving the
files from the win.vc to the win directory and updating the README file.

----------------------------------------------------------------------

Comment By: Decoster Jos (decosterjos)
Date: 2012-07-16 07:01

Message:
To build Thread in a 'Betteries' included' Tcl, under the pkgs directories,
one of the following needs to be done:

- put all files of tcl/pkgs/thread/win/vc in thread/win and adapt the ROOT
in the thread makefile.vc 

or

- modify tcl/win/makefile.vc to also look in pkgs/???/win/vc directories

I prefer to remove the thread/win/vc directory.

----------------------------------------------------------------------

Comment By: Zoran Vasiljevic (vasiljevic)
Date: 2012-07-12 10:57

Message:
Don, I have, as already stated, no experience with Windows build.
I must say I did not understand your answer :-(
Do I need to do anything? I normally fresh-clone the distro, make 
changes, commit and push. 

----------------------------------------------------------------------

Comment By: Don Porter (dgp)
Date: 2012-07-12 10:44

Message:

This was corrected before in checkin 6593e21b9c.

It got broken again in checkin 51cf545767.

There's a natural tug-o-war going on between making
builds work in a fossil checkout and making them work
in the released distribution.  Unless there's some value
in having those two keep different directory layouts, I
recommend getting rid of the vc subdir from the very beginning.

Otherwise we'll just keep fixing this again and again.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=3543020&group_id=10894