|
From: SourceForge.net <no...@so...> - 2012-04-03 09:36:35
|
Bugs item #3514475, was opened at 2012-04-03 02:36 Message generated for change (Tracker Item Submitted) made by nijtmans You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=110894&aid=3514475&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 52. Portability Support Group: development: 8.6b2 Status: Open Resolution: None Priority: 5 Private: No Submitted By: Jan Nijtmans (nijtmans) Assigned to: Jan Nijtmans (nijtmans) Summary: remove TclpGetTimeZone and TclpGetTZName Initial Comment: In bug fix [1163422]: "FormatClock clockVal size mismatch", (Kevin Kenny, 2005-03-15) the signature of the function TclpGetTimeZone was changed. The argument of this function was changed from unsigned long to Tcl_WideInt, which is binary incompatible. This signature change was done in the core-8-4-branch only, in core-8-5-branch and trunk the argument is still unsigned long. So that's binary incompatible (that's what this bug is about) and it means that bug 1163422 is only fixed in core-8-4-branch, not in core-8-5-branch and trunk. The question is, how bad is this. Answer: not bad at all, because apparently no extension uses this. Tcl 8.5 has a new clock implementation in which the functions TclpGetTimeZone and TclpGetTZName are no longer used. TclpGetTZName was for mac and win only, so this function is not portable anyway. So, the solution is simple: remove those two functions completely for Tcl 8.6. (I already implemented TclpGetTZName for Cygwin, but this change means that that's no longer necessary, so I plan to remove this cygwin implementation in the core-8-4-branch and core-8-5-branch as well). Any objections? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=110894&aid=3514475&group_id=10894 |