[Tcl-bugs] [ tcl-Patches-3124683 ] platform specific stuff in (tcl|tk)Main.c

[SourceForge.net <no...@so...>]

Patches item #3124683, was opened at 2010-12-01 17:18
Message generated for change (Comment added) made by nijtmans
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=310894&aid=3124683&group_id=10894

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: 50. Embedding Support
Group: None
>Status: Pending
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Jan Nijtmans (nijtmans)
Assigned to: Don Porter (dgp)
Summary: platform specific stuff in (tcl|tk)Main.c

Initial Comment:
Don Porter wrote to me:
> I suspect there may be another way, and you may be overlooking some
> encoding support routines that can keep platform specific stuff out
> of the generic/*.c files.  But I could also be wrong about that.

Here is my attempt to move as most as possible platform-dependant
stuff out of (tcl|tk)Main.c.

- Implemented a static NewNativeObj() function, so we no longer have to
  Tcl_SetStartupScript using native encoding, en then later read it again
  and convert it to UTF-8. Now every native-to-obj conversions can be
  done in one step.
- 

And for tkMain.c, there are some additional
improvements:

- converted ThreadSpecificData in InteractiveState (just as
already done in tclMain.c), wich an additional 'gotPartial'
field. This makes Tk_MainEx thread-safe. Moved the
inChannel and tty variables there too.
- Use the InteractiveState as clientData in
  Tcl_CreateChannelHandler, so we still can unregister
  when stdin becomes invalid.
- use Tcl_GetStdChannel(TCL_STDOUT) in stead of
  Tcl_GetChannel(interp, "stdout", NULL), as in tclMain.c

Regards,
         Jan Nijtmans

----------------------------------------------------------------------

>Comment By: Jan Nijtmans (nijtmans)
Date: 2011-03-17 17:19

Message:
Fixed in HEAD now (Both for Tcl and Tk)

OK?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=310894&aid=3124683&group_id=10894