[Tcl-bugs] [ tcl-Bugs-3202171 ] namespace code simplification incorrect

[SourceForge.net <no...@so...>]

Bugs item #3202171, was opened at 2011-03-07 15:17
Message generated for change (Comment added) made by dgp
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=3202171&group_id=10894

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: 21. [namespace]
Group: current: 8.5.9
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Don Porter (dgp)
>Assigned to: Donal K. Fellows (dkf)
Summary: namespace code simplification incorrect

Initial Comment:

Demo script:

% namespace eval demo {
proc namespace args {puts $args}
::namespace code {namespace inscope foo}
}
namespace inscope foo

[::namespace code] tries to detect and simplify cases where
it would produce nested [::namespace inscope] calls.  In the
case where a namespace has its own custom "namespace"
command, though, this is not correct.



----------------------------------------------------------------------

>Comment By: Don Porter (dgp)
Date: 2011-03-09 10:00

Message:
Fix is in checkin

http://core.tcl.tk/tcl/info/ac4c249ecf

Please review, and if acceptable, either merge
to core branch, or give me the ok to do so.


----------------------------------------------------------------------

Comment By: Don Porter (dgp)
Date: 2011-03-08 16:12

Message:

Note, this analysis also implies that 
tests namespace-22.2 and namespace-22.3 
are incorrect.

----------------------------------------------------------------------

Comment By: Don Porter (dgp)
Date: 2011-03-07 15:22

Message:
Since there's no way I can think of to deal with the
possibility of the renaming of commands between the
time [namespace code] quotes a script, and the time
the quoted script is eval's by a callback operation, that
weakness may just have to be accepted.  The bug demo
submitted ought to be fixable though.

----------------------------------------------------------------------

Comment By: Don Porter (dgp)
Date: 2011-03-07 15:19

Message:
There is also a more fundamental design flaw
that the functioning of [namespace code] appears to
rely on an assumption that the [::namespace] command
is never [rename]d.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=3202171&group_id=10894