[Tcl-bugs] [ tcl-Feature Requests-1112654 ] eliminate double substitution from configure.in

[SourceForge.net <no...@so...>]

Feature Requests item #1112654, was opened at 2005-01-30 09:28
Message generated for change (Settings changed) made by hobbs
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=360894&aid=1112654&group_id=10894

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: 85. tclconfig
Group: None
>Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Joe English (jenglish)
Assigned to: Jeffrey Hobbs (hobbs)
Summary: eliminate double substitution from configure.in

Initial Comment:
MSW reports (on the chat) that latest changes to
configure.in / tcl.m4 (#1081595) break the build on NetBSD.

Problem: "configure produces makefile targets like
libtcl`echo ... | tr -d ...`".

----------------------------------------------------------------------

Comment By: Don Porter (dgp)
Date: 2005-06-01 15:28

Message:
Logged In: YES 
user_id=80530


the remaining request here
(re-opening) is to get rid of 
any remaining "eval"s in
configure.in / tcl.m4 .

Most of the eval's were there
originally to substitute $(TCL_DBGX),
but that's gone now. so they
ought to be able to go too.

The presence of eval's makes
it more difficult to solve the
problem of handling spaces in
pathnames (554348).

----------------------------------------------------------------------

Comment By: Joe English (jenglish)
Date: 2005-05-31 10:10

Message:
Logged In: YES 
user_id=68433

> Is there anything here to fix?

Not that I'm aware of.  It would be _nice_ to get rid of all
the double-evals in configure.in, but not _necessary_ afaict.

----------------------------------------------------------------------

Comment By: Jeffrey Hobbs (hobbs)
Date: 2005-05-30 18:51

Message:
Logged In: YES 
user_id=72656

Is there anything here to fix?

----------------------------------------------------------------------

Comment By: Don Porter (dgp)
Date: 2005-01-31 08:26

Message:
Logged In: YES 
user_id=80530


Committed the generated
unix/configure file.

Moving this report over to
a Feature Request.  Let us please
find a way to solve these problems
without using an "eval".  

Getting rid of the double 
substitution was going to be
an important step toward fixing
Bug 553544.

----------------------------------------------------------------------

Comment By: Joe English (jenglish)
Date: 2005-01-30 10:44

Message:
Logged In: YES 
user_id=68433

Reopening -- I have autoconf 2.59, not 2.57, so can't
regenerate the configure script.  Jeff, could you take care
of this?  Thanks.

(BTW, why are we using 2.57?)

----------------------------------------------------------------------

Comment By: Joe English (jenglish)
Date: 2005-01-30 10:39

Message:
Logged In: YES 
user_id=68433

Patch confirmed.  Also checked tk/unix/configure.in for
similar issues; no double-evals were removed in the DBGX
purge, Tk CVS HEAD compiles OK on NetBSD.

What's not clear is whether NetBSD even needs to use
${TCL_TRIM_DOTS} anymore, but that's an issue for another time.

----------------------------------------------------------------------

Comment By: Joe English (jenglish)
Date: 2005-01-30 09:58

Message:
Logged In: YES 
user_id=68433

Followup: Double-eval is also required for TCL_STUB_LIB_FILE.

We should really consider handling this TCL_TRIM_DOTS /
TCL_LIB_VERSIONS_OK / TCL_{UN}SHARED_LIB_SUFFIX mess
differently.


----------------------------------------------------------------------

Comment By: Joe English (jenglish)
Date: 2005-01-30 09:33

Message:
Logged In: YES 
user_id=68433

Probable cause of the problem:  the line

| eval "TCL_LIB_FILE=${TCL_LIB_FILE}"

(configure.in r1.125 line 448), which was removed in r1.126,
is actually used for more than just expanding ${TCL_DBGX}. 
In particular, if TCL_LIB_VERSIONS_OK is set to "nodots", it
contains other shell escapes.

Attached patch attempts to fix the problem by restoring this
line.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=360894&aid=1112654&group_id=10894